Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hapi dependencies to use new scoped @hapi packages #77

Merged
merged 4 commits into from
May 11, 2019
Merged

Fix hapi dependencies to use new scoped @hapi packages #77

merged 4 commits into from
May 11, 2019

Conversation

quantumdream
Copy link

Change dependencies to the new scoped hapi packages to get rid of the deprecation warnings and to make sure new updates to these packages are used in hapi-pino as well.

Updated example, index and tests to use the new packages accordingly, functionality wise nothing changes.

@coveralls
Copy link

coveralls commented Apr 26, 2019

Coverage Status

Coverage remained the same at 98.808% when pulling 5710aaa on quantumdream:master into e5530ee on pinojs:master.

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you avoid the reformatting of the source code? This project is not using prettier.

@quantumdream
Copy link
Author

I restored the old formatting, my bad, didn't check.

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Collaborator

It seems this branch has some conflicts. Can you resolve them? Thanks!

@quantumdream
Copy link
Author

Should be good to go now!

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit fbb8367 into hapijs:master May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants