-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hapi dependencies to use new scoped @hapi packages #77
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you avoid the reformatting of the source code? This project is not using prettier.
I restored the old formatting, my bad, didn't check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It seems this branch has some conflicts. Can you resolve them? Thanks! |
Should be good to go now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change dependencies to the new scoped hapi packages to get rid of the deprecation warnings and to make sure new updates to these packages are used in hapi-pino as well.
Updated example, index and tests to use the new packages accordingly, functionality wise nothing changes.