-
Notifications
You must be signed in to change notification settings - Fork 194
Create a basic HTTP server #1
Comments
Maybe a standard way to post PR will be helpful in the future e.g. every PR for this assignment looks like |
I'm ok with that. Generally, github links to this issue are enough for me. |
[ Assignment #1 ] Basic HTTP server |
Since I can't provide this level of detail on every pull request, here are all the generally applicable comments collected as I am reviewing all the submissions:
|
Some more:
As you can see, those submitting early get a more detailed personal code review. I go over the pull request in order and once I make a comment, I reflect it here for everyone else because repeating it over and over again isn't practical. It is important to read the full assignment notes and review your code even if I didn't comment on it. Pretty much every submission had issues. |
@oluoluoxenfree if I understand correctly, for the first assignment, it was supposed to be a basic server. It could as well be started as |
@rutaihwa Sorry for deleting I meant to edit, thank you! |
@oluoluoxenfree just put any of the keywords and a reference to the issue in the description like |
@AdriVanHoudt Thank you! Sorry for cluttering up the issue with questions, won't happen again. |
Thanks @oluoluoxenfree I had overlooked that my self, thanks for the question. |
@oluoluoxenfree np and this is issue is for questions so feel free to ask whatever you want. If you need general Hapi help check out the gitter https://gitter.im/hapijs/hapi or https://github.com/hapijs/contrib |
Thanks a lot for your time and this was very helpful. |
It makes it easier to find what PR is related to what issue and vica versa, not so much needed now but helps when dealing with multiple PR's and issues |
A hapijs server with the below characteristics: - lib folder - package.json file Package file defines hapijs as a project dependency. - An initial index.js file - Server is created on port 8000. - A route accepting /version requests and replies { "version":"0.0.1" } json payload. Above version response comes from package.json file.
A hapijs server with the below characteristics: - lib folder - package.json file Package file defines hapijs as a project dependency. - An initial index.js file - Server is created on port 8000. - A route accepting /version requests and replies { "version":"0.0.1" } json payload. Above version response comes from package.json file.
A hapijs server with the below characteristics: - lib folder - package.json file Package file defines hapijs as a project dependency. - An initial index.js file - Server is created on port 8000. - A route accepting /version requests and replies { "version":"0.0.1" } json payload. Above version response comes from package.json file.
Quick note about |
@hueniverse thanks for the clarification! How come no example on hapijs.com does this? Because the examples are too trivial? |
@AdriVanHoudt probably because I didn't write them... :-) |
@hueniverse haha |
@hueniverse thanks for the clarification on |
I think I committed, PR's, and commented with 'closes #1' correctly. Can someone confirm? |
* outmoded/university#1 * hapis v12 * node v4 and above. * ES6
Let's get started!
First, we need some basic structure: a
lib
folder, apackage.json
file, and an initialindex.js
. Since we will be using hapi, we need to include that in the project dependencies.Second, create a basic hapi server on port 8000 which responds to
/version
requests and replies with a simple{ "version": "0.0.1" }
JSON payload. The version in the response should come from thepackage.json
file.Assignment due: 3/17
Got questions or need help? Post a comment.
The text was updated successfully, but these errors were encountered: