2732#connection properties type-safe guarding

[MuraraAllan]

Related to #2732

Changes proposed in this pull request:

• connection properties type-safe guarding

Checklist:

• docs updated
• tests updated
• Changes updated

[MuraraAllan]

@msimerson LFR

I added some logs also to clarify we entered the "null guard at x function"

I just catch and fixed some other throw points in case of connection null.
I also saw some code here and there null guarding the same way for other variables, maybe a "remove unsafe null guard and add log" task would come handy, what do you think?

I believe I forgot something on CI 😨 Can you help me with that?

[msimerson]

I don't think we need the additional logging. When these conditions are hit, it's not an error or unexpected, and log entries for ended transactions tend to be confusing.

Also, which is easier to read and looks better in the code?

falsy

    let results = connection.transaction?.results || connection.results;

w/o falsy

    let results = connection.results;
    if (connection.transaction != null) {
        results = connection.transaction.results;
    }

[lgtm-com]

This pull request introduces 2 alerts when merging 1a883ce into 4afc7b1 - view on LGTM.com

new alerts:

• 2 for Useless conditional

[MuraraAllan]

@msimerson Sorry long time no see

Hey, I'm not sure if this error on CI windows 16x happens because of GCC, build-essential.

Fallback to falsy check
Removed logs
Type-guarded some other occurrences

[MuraraAllan]

Looks like sqlite3 doesn't work on 16.x, I fallback ci-test-win to only 14.x, ok?