Updating all sources of block.Transactions and do the corresponding work for block staking txns #2655
Conversation
denniswon
requested review from
rlan35,
fxfactorial,
LeoHChen,
gupadhyaya,
Daniel-VDM and
a team
denniswon
changed the title
|
Jenkins, test this please. |
|
@rlan35 @fxfactorial note that this pr is based on top of #2554. Just changed the base of this PR to be harmony-one:stakingtxn_history which reflects denniswon:stakingtxn_history branch for the parent pr (for the ease of reviewing). Once the parent pr is merged to master, will rebase the pr to reflect based on origin master. Since this is an open source repo where we submit prs from forked repos, no better way for doing stacked/dependent prs. Let me know if anyone has a better method. @harmony-one/core |
denniswon
force-pushed
the
staking
branch
2 times, most recently
from
6176d40 to
ea54bba
Compare
denniswon
force-pushed
the
stakingtxn_history
branch
from
87d3a5b to
10dac9b
Compare
denniswon
force-pushed
the
staking
branch
2 times, most recently
from
603455e to
98ec38d
Compare
|
looks good, approve after comments addressed |
|
usually if you have a dependency cycle on your own PRs, then you commit whatever you need in both. Then first PR gets merged, then you rebase your second PR off your merged first PR, then you force push on the second PR. |
|
@fxfactorial updated per review. |
|
@fxfactorial updated per review. |
…ted in SetReceiptsData
Updating all sources of block.Transactions and do the corresponding work for staking txns.
Prevent future bad blocks, needed for fast state sync in the future (refer to InsertReceiptChain function), etc.
Test
build harmony binary
unit test passes
local network achieves consensus as normal
Unit Test Coverage