-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPC for staking txns and txns history queries #2554
Conversation
189041e
to
cf4d4a0
Compare
Note. With force push above, #2553 has been merged to this pr. @gupadhyaya I made the changes based on your review on that pr here on commit |
cf4d4a0
to
30ecb35
Compare
30ecb35
to
ad6f3b7
Compare
aaf0b02
to
0d89daa
Compare
@gupadhyaya updated per review. |
But I do see the new rpcs getting called correctly
On my own explorer node, having some trouble inserting new blocks to the db |
I also see this when my explorer node is syncing. cc: @fxfactorial any idea by chance? [UPDATE] Resolved later during syncing. I guess this happens after hard refresh when not enough nodes are there on the network. |
@denniswon could you please fix the Jenkins build? |
@gupadhyaya jenkins has been disabled. |
87d3a5b
to
3649ffc
Compare
f181d32
to
c8df6e3
Compare
@gupadhyaya reverted the apiv1 change in transactionpool and jenkins/travis all passed. final review to be merged so that this pr can be included in tmrw's ostn upgrade. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
* Added support for using AWS encrypted BLS key files (#2650) * added bls support, cleaned the code * fixed code per review * [build] fix the release action for static build Signed-off-by: Leo Chen <leo@harmony.one> * [build] remove double / in FOLDER Signed-off-by: Leo Chen <leo@harmony.one> * [blsgen] LoadFromKey with passphrase more robustly (#2675) * [project] Remove txgen, prefer stack based init & map literals (#2678) * [project] Remove unused internal memprofiling, profiling, metrics service (#2679) * [project] Remove unused internal memprofiling, profiling * [internal] Unused attack package * [internal] More dead metrics related code * [offchain] Forgot removal of ! which did not write the reward-per-key to work (#2681) * [project] Fix first round issue from static analysis check (#2682) * RPC for staking txns and txns history queries (#2554) * staking txn. look up by hash fix on api backend rawdb storage * node explorer staking txn 'history' RPC layer support * fix unit test * add error log when explorer node db instance cannot be fetched * revert unwanted merge changes during rebase * use already encoded tx message fields for get staking txn rpc * update explorer node storage service for staking txns * use hex string for staking transaction data field * revert transaction pool apiv1 changes * [blockchain] More info in failed validator voting power update (#2685) Co-authored-by: coolcottontail <50373379+coolcottontail@users.noreply.github.com> Co-authored-by: Leo Chen <leo@harmony.one> Co-authored-by: Edgar Aroutiounian <edgar.factorial@gmail.com> Co-authored-by: Jong Hyuck Won <denniswon@users.noreply.github.com>
* Merge master t3 0402 (#2686) * Added support for using AWS encrypted BLS key files (#2650) * added bls support, cleaned the code * fixed code per review * [build] fix the release action for static build Signed-off-by: Leo Chen <leo@harmony.one> * [build] remove double / in FOLDER Signed-off-by: Leo Chen <leo@harmony.one> * [blsgen] LoadFromKey with passphrase more robustly (#2675) * [project] Remove txgen, prefer stack based init & map literals (#2678) * [project] Remove unused internal memprofiling, profiling, metrics service (#2679) * [project] Remove unused internal memprofiling, profiling * [internal] Unused attack package * [internal] More dead metrics related code * [offchain] Forgot removal of ! which did not write the reward-per-key to work (#2681) * [project] Fix first round issue from static analysis check (#2682) * RPC for staking txns and txns history queries (#2554) * staking txn. look up by hash fix on api backend rawdb storage * node explorer staking txn 'history' RPC layer support * fix unit test * add error log when explorer node db instance cannot be fetched * revert unwanted merge changes during rebase * use already encoded tx message fields for get staking txn rpc * update explorer node storage service for staking txns * use hex string for staking transaction data field * revert transaction pool apiv1 changes * [blockchain] More info in failed validator voting power update (#2685) Co-authored-by: coolcottontail <50373379+coolcottontail@users.noreply.github.com> Co-authored-by: Leo Chen <leo@harmony.one> Co-authored-by: Edgar Aroutiounian <edgar.factorial@gmail.com> Co-authored-by: Jong Hyuck Won <denniswon@users.noreply.github.com> * [validator] Hide one field from JSON (#2705) * [rpc] Show both latest header of beacon chain and shard chain (#2714) Co-authored-by: Leo Chen <leo@harmony.one> Co-authored-by: coolcottontail <50373379+coolcottontail@users.noreply.github.com> Co-authored-by: Edgar Aroutiounian <edgar.factorial@gmail.com> Co-authored-by: Jong Hyuck Won <denniswon@users.noreply.github.com>
Issue
NOTE: This PR is rebased on my other PR #2553.
#2227
#2346
Test
~/go/src/github.com/harmony-one/harmony (stakingtxn_history) $ go test ./core/rawdb
ok github.com/harmony-one/harmony/core/rawdb
Test/Run Logs
Run local network with explorer node, make a query to its rpc query endpoint, and verify that getStakingTransactionsHistory() RPC returns the correct history of staking txns of an account.
Operational Checklist
Requires rolling update. Other than this, not much risk involved/foreseen.