[offchain] Forgot removal of ! which did not write the reward-per-key… #2681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlan35
approved these changes
Apr 2, 2020
fxfactorial
added a commit
that referenced
this pull request
Apr 2, 2020
* Added support for using AWS encrypted BLS key files (#2650) * added bls support, cleaned the code * fixed code per review * [build] fix the release action for static build Signed-off-by: Leo Chen <leo@harmony.one> * [build] remove double / in FOLDER Signed-off-by: Leo Chen <leo@harmony.one> * [blsgen] LoadFromKey with passphrase more robustly (#2675) * [project] Remove txgen, prefer stack based init & map literals (#2678) * [project] Remove unused internal memprofiling, profiling, metrics service (#2679) * [project] Remove unused internal memprofiling, profiling * [internal] Unused attack package * [internal] More dead metrics related code * [offchain] Forgot removal of ! which did not write the reward-per-key to work (#2681) * [project] Fix first round issue from static analysis check (#2682) * RPC for staking txns and txns history queries (#2554) * staking txn. look up by hash fix on api backend rawdb storage * node explorer staking txn 'history' RPC layer support * fix unit test * add error log when explorer node db instance cannot be fetched * revert unwanted merge changes during rebase * use already encoded tx message fields for get staking txn rpc * update explorer node storage service for staking txns * use hex string for staking transaction data field * revert transaction pool apiv1 changes * [blockchain] More info in failed validator voting power update (#2685) Co-authored-by: coolcottontail <50373379+coolcottontail@users.noreply.github.com> Co-authored-by: Leo Chen <leo@harmony.one> Co-authored-by: Edgar Aroutiounian <edgar.factorial@gmail.com> Co-authored-by: Jong Hyuck Won <denniswon@users.noreply.github.com>
fxfactorial
added a commit
that referenced
this pull request
Apr 4, 2020
* Merge master t3 0402 (#2686) * Added support for using AWS encrypted BLS key files (#2650) * added bls support, cleaned the code * fixed code per review * [build] fix the release action for static build Signed-off-by: Leo Chen <leo@harmony.one> * [build] remove double / in FOLDER Signed-off-by: Leo Chen <leo@harmony.one> * [blsgen] LoadFromKey with passphrase more robustly (#2675) * [project] Remove txgen, prefer stack based init & map literals (#2678) * [project] Remove unused internal memprofiling, profiling, metrics service (#2679) * [project] Remove unused internal memprofiling, profiling * [internal] Unused attack package * [internal] More dead metrics related code * [offchain] Forgot removal of ! which did not write the reward-per-key to work (#2681) * [project] Fix first round issue from static analysis check (#2682) * RPC for staking txns and txns history queries (#2554) * staking txn. look up by hash fix on api backend rawdb storage * node explorer staking txn 'history' RPC layer support * fix unit test * add error log when explorer node db instance cannot be fetched * revert unwanted merge changes during rebase * use already encoded tx message fields for get staking txn rpc * update explorer node storage service for staking txns * use hex string for staking transaction data field * revert transaction pool apiv1 changes * [blockchain] More info in failed validator voting power update (#2685) Co-authored-by: coolcottontail <50373379+coolcottontail@users.noreply.github.com> Co-authored-by: Leo Chen <leo@harmony.one> Co-authored-by: Edgar Aroutiounian <edgar.factorial@gmail.com> Co-authored-by: Jong Hyuck Won <denniswon@users.noreply.github.com> * [validator] Hide one field from JSON (#2705) * [rpc] Show both latest header of beacon chain and shard chain (#2714) Co-authored-by: Leo Chen <leo@harmony.one> Co-authored-by: coolcottontail <50373379+coolcottontail@users.noreply.github.com> Co-authored-by: Edgar Aroutiounian <edgar.factorial@gmail.com> Co-authored-by: Jong Hyuck Won <denniswon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.