[p2p] higher weight to process node messages #3227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Total number of weight is 8192+8192=16384 weight of consensus message is 1 weight of node message / tx is 64 This is to prevent massive number of tx messages from getting the node OOM. Signed-off-by: Leo Chen <leo@harmony.one>
|
I would recommend to use two different |
Agree, if we give node message 64, then certainly people can spam with node message and block consensus message from being processed. |
|
replaced by #3232 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Total number of weight is 8192+8192=16384
weight of consensus message is 1
weight of node message / tx is 64
This is to prevent massive number of tx messages from getting the node OOM.
Signed-off-by: Leo Chen leo@harmony.one