Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate channel for different messages #3232

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Separate channel for different messages #3232

merged 2 commits into from
Jul 17, 2020

Conversation

LeoHChen
Copy link
Contributor

No description provided.

Leo Chen added 2 commits July 17, 2020 08:58
[p2p] reject empty p2p messages
c7b8b1d 
Signed-off-by: Leo Chen <leo@harmony.one>
[p2p] separate handler channel for consensus/node messages
f618354 
Signed-off-by: Leo Chen <leo@harmony.one>
@LeoHChen LeoHChen requested review from JackyWYX and rlan35 July 17, 2020 09:41
@LeoHChen LeoHChen mentioned this pull request Jul 17, 2020
Closed
JackyWYX
JackyWYX approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@JackyWYX JackyWYX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@LeoHChen LeoHChen merged commit 85062a3 into harmony-one:main Jul 17, 2020
@LeoHChen LeoHChen deleted the separate_channel_for_msg branch July 17, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackyWYX JackyWYX JackyWYX approved these changes

@rlan35 rlan35 Awaiting requested review from rlan35

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeoHChen @JackyWYX