New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rosetta Implementation - pt2 (Stage 3.2 of Node API Overhaul) #3312

Merged

Daniel-VDM merged 39 commits into harmony-one:main from Daniel-VDM:rosetta-network

Aug 25, 2020

Contributor

Daniel-VDM commented Aug 22, 2020 •

edited

Loading

Stage 3.2 of Node API Overhaul

This PR implements Rosetta's /network & /block node endpoint services.

This PR also adds unit tests to the rosetta package to ensure correct formatting behavior.

Basic functionality was tested using a fork of Rosetta's CLI (to check transactions). Edge case testing with a testnet node is currently being done (8/22).

Here is the unit test coverage:

PASS
coverage: 56.0% of statements
ok  	github.com/harmony-one/harmony/rosetta/services	0.413s

As we don't currently have an easy way to create a mock harmony object, this is probably the best we can do without investing a bunch of time to create a testing package (which I think we should do at some point).

Daniel-VDM added the rpc label

Daniel-VDM requested review from rlan35, LeoHChen, gupadhyaya and JackyWYX

August 22, 2020 20:06

Daniel-VDM self-assigned this

rlan35 approved these changes

View reviewed changes

Contributor

rlan35 left a comment

generally looks good.

node/api.go Outdated Show resolved Hide resolved

rosetta/services/block.go Show resolved Hide resolved

LeoHChen approved these changes

View reviewed changes

Contributor

LeoHChen left a comment

LGTM. Is rosetta api test part of regression now? also, can we add it to nightly?

rosetta/rosetta.go Outdated Show resolved Hide resolved

Contributor Author

Daniel-VDM commented Aug 25, 2020

LGTM. Is rosetta api test part of regression now? also, can we add it to nightly?

We don't have all the endpoints implemented yet for the rosetta integration test. Will add it as part of the PR testing process after implementation, and can add it as a stage to the nighly check afterward.

Daniel-VDM added 21 commits

August 24, 2020 21:37


          [rosetta] Add server stop

741e88b

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Make network naming consistent

f981ecc

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Correct common package name & add error enum

b9acfd5

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Remove needless forward of network info to services

49ec2df

* Implement /network/list

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Refactor errors & add operation statuses and types

b5f355d

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Implement NetworkOptions & update NetworkAPIService

4e2eae7

* Rename *_service.go files to remove the suffix
* Update StartServers to use new operation types

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Impl NetworkStatus - Finish init impl of /network endpoint

1127be3

* Fix import structure for rosetta.go

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [test] Make explorer run as archival for localnet

79f7871

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Add unit tests

a5a4623

* Force errors to remain the same with unit tests
* Force operations to remain the same with unit tests
* Ensure network checking works for all cases with unit tests

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Add InvalidNetworkError and correct error codes

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Add UnmarshalFromInterface for SubNetworkMetadata

d861764

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Add network checking

2c1d478

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Nit fixes & add unit test for Peer Info

814e467

* Make names consistent

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Add BlockNotFoundError & TransactionNotFoundError

b8871de

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Implement skeleton for block transactions

e689609

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Add ReceiptNotFoundError

a2952da

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Add receipt to formatTransaction sig for contract fails

bd43dcd

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Add currency, ExpendGasOperation, & ContractCreationOperation

935d8c9

* Add Error creator

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Init impl of plain transaction formatting

1ddcc6e

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Update network.go for new error constructor

f77f09c

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Implement stx formatter & refactor BlockTransaction

9bf9ca8

* Updated todo comments & function formatting

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>

Daniel-VDM added 16 commits

August 24, 2020 21:37


          [rosetta] Impl Block & make currency non-ptr for easy copy with custo…

38365e8

…m metadata

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Fix collect rewards amount on transaction fetch

0c858d5

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Fix block look-up edge case & add recovery middleware

693849f

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Add bocks unit tests

3df253e

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Fix checkPeerID unit test in network_test.go

b013d49

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Fix staking tx amount for tx ops & update inline docs

a2d0b31

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Fix lint

d83259d

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Refactor getStakingOperations

305dc29

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Fix undelegate value

03ea011

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Nit - fix formatting for network.go

6f1e46c

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [node] Move genesis allocation to core & remove unused ContractDeploy…

280126a

…erKey

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Fix precision error & add cx receipt hash on blk fetch

24d86dd

* Add unit tests for supporting helper functions

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Fix fmt

86fe62a

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [rosetta] Fix cx receipt hashes for blocks

be82657

* Print stack trace on panic recovery

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [node] Nit - fix comment for StopRosetta

595005c

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>


          [node] Expose GetMaxPeerHeight

01127e3

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>

Daniel-VDM force-pushed the rosetta-network branch from fb05de6 to 8497462 Compare

August 25, 2020 05:46

Daniel-VDM requested a review from rlan35

August 25, 2020 05:46


          [rosetta] Add SyncStatus enum

d606987

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>

Daniel-VDM force-pushed the rosetta-network branch from 8497462 to d606987 Compare

August 25, 2020 06:04


          [rosetta] Nit - remove redundant 'service' name in services namespace

ecc8346

Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>

Contributor

rlan35 commented Aug 25, 2020

looks good.

Daniel-VDM merged commit 0f0166f into harmony-one:main

This was referenced Aug 26, 2020

Node API Overhaul (Design & Planning) #3210

Closed

Rosetta Implementation - pt2 FIX (Stage 3.2 of Node API Overhaul) #3321

Merged

Daniel-VDM mentioned this pull request

Rosetta Implementation - pt2 FIX2 (Stage 3.2 of Node API Overhaul) #3338

Merged

Daniel-VDM mentioned this pull request

Rosetta Implementation Tracker #3381

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rpc