Rosetta Implementation - pt2 FIX (Stage 3.2 of Node API Overhaul) #3321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
* Add getBlockSigner info * Rename vars named block to blk for pkg imports * Add unit tests for block reward formatting Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
rlan35
reviewed
Aug 27, 2020
…dsAndCountSigs * Change committee to signers for blockSignerInfo Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Codecov Report
@@ Coverage Diff @@
## main #3321 +/- ##
=======================================
Coverage ? 34.54%
=======================================
Files ? 209
Lines ? 24644
Branches ? 0
=======================================
Hits ? 8513
Misses ? 15482
Partials ? 649 Continue to review full report at Codecov.
|
* Correct network chain for sync status Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
rlan35
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stage 3.2 FIX of Node API Overhaul
This PR is related to #3312 .
This fixes some decimal precision errors as well as add 'accounting' transactions for block rewards in the pre-staking era.
Block reward operations on respective blocks/transactions will look a little something like this:
{ "Type": "PreStakingBlockReward", "Operations": [ { "operation_identifier": { "index": 0 }, "type": "PreStakingBlockReward", "status": "success", "account": { "address": "one13rnn8uawlpqpcsh0hpm2k26xxusq639wkvl7r5", "metadata": { "hex_address": "0x88E733F3AEF8401c42EfB876Ab2B4637200d44AE" } }, "amount": { "value": "113207547169811320", "currency": { "symbol": "ONE", "decimals": 18 } } } ], "Currencies": [ { "symbol": "ONE", "decimals": 18 } ], "NilAmountPresent": false }This PR also refactors 'special' transactions (genesis & block rewards) into their own functions for clarity.
This PR changes the special transaction identifier to fit the format:
<block_hash>_<Bech-32_Address>. The related machinery has been made to easily change this format, should we want to change it before release.This PR also fixes the
getBlockSignersRPC, with an added test here.This PR also updates the go.mod file as I could not build on my machine without re-syncing dependencies (to get the go.mod file in this PR).