Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump harvester-load-balancer to v0.2.5 #234

Closed
wants to merge 1 commit into from

Conversation

w13915984028
Copy link
Member

To fix harvester/harvester#5137, the harvester-load-balancer image has a new v0.2.5 release.

Bump a new chart v0.2.5 release to Harvester.

Signed-off-by: Jian Wang <w13915984028@gmail.com>
@w13915984028
Copy link
Member Author

This PR looks to be redundant, unless the chart itself is changed, new commits to controller master-head will be auto fetched by the new ISO.

@bk201 please help double confirm, thank.

Refer: harvester/harvester#5137 (comment)

///
After PR harvester/load-balancer-harvester#26 is merged, a new master-head image of harvester-load-balancer is built.

The harvester/harvester-installer will always use the master-head image of harvester-load-balancer to build-iso. With a latest local build ISO, the issue is verifyed to be solved.

https://github.com/harvester/harvester/blob/a2c98e9606eec79c839c5bed095cc32fc1616b3c/deploy/charts/harvester/values.yaml#L453

harvester-load-balancer:
  enabled: false
  image:
    imagePullPolicy: Always
    repository: rancher/harvester-load-balancer
    tag: master-head
  webhook:
    image:
      imagePullPolicy: IfNotPresent
      repository: rancher/harvester-load-balancer-webhook
      tag: master-head

@bk201
Copy link
Member

bk201 commented Mar 13, 2024

Yes, you are correct. If a chart doesn't change, we just need a PR to bump the image tag in release branches: https://github.com/harvester/harvester/blob/f8469881441b92a71c6e58a493f433eccf5f3ba1/deploy/charts/harvester/values.yaml#L458, can you help create a PR for it? Thanks.

Bumping a chart when its image changes is also OK, but it is only useful when you use the chart without harvester or for testing/dev purposes.

Copy link
Member

@starbops starbops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit, else LGTM. Thank you.

@@ -8,7 +8,7 @@ image:
repository: rancher/harvester-load-balancer
pullPolicy: IfNotPresent
# Overrides the image tag whose default is the chart appVersion.
tag: v0.2.0
tag: v0.2.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image tag defaults to the chart appVersion, so we can drop the explicit version string unless we need something else here.

Suggested change
tag: v0.2.5
tag: ""

@w13915984028
Copy link
Member Author

The harvester-load-balancer chart is not used out of Harvester cluster. Instead of releasing a new chart version, just bump the image tag in Harvester v1.3 branch.

This PR is replaced by harvester/harvester#5354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants