-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump harvester-load-balancer to v0.2.5 #234
Conversation
Signed-off-by: Jian Wang <w13915984028@gmail.com>
This PR looks to be redundant, unless the chart itself is changed, new commits to controller master-head will be auto fetched by the new ISO. @bk201 please help double confirm, thank. Refer: harvester/harvester#5137 (comment) /// The harvester/harvester-installer will always use the
|
Yes, you are correct. If a chart doesn't change, we just need a PR to bump the image tag in release branches: https://github.com/harvester/harvester/blob/f8469881441b92a71c6e58a493f433eccf5f3ba1/deploy/charts/harvester/values.yaml#L458, can you help create a PR for it? Thanks. Bumping a chart when its image changes is also OK, but it is only useful when you use the chart without harvester or for testing/dev purposes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit, else LGTM. Thank you.
@@ -8,7 +8,7 @@ image: | |||
repository: rancher/harvester-load-balancer | |||
pullPolicy: IfNotPresent | |||
# Overrides the image tag whose default is the chart appVersion. | |||
tag: v0.2.0 | |||
tag: v0.2.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image tag defaults to the chart appVersion, so we can drop the explicit version string unless we need something else here.
tag: v0.2.5 | |
tag: "" |
The This PR is replaced by harvester/harvester#5354 |
To fix harvester/harvester#5137, the harvester-load-balancer image has a new v0.2.5 release.
Bump a new chart v0.2.5 release to Harvester.