Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kubevirt to v1.1.0, k8s to v1.26.10, Harvester to v1.3.0 #26

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

w13915984028
Copy link
Member

@w13915984028 w13915984028 commented Mar 8, 2024

Solve issue: harvester/harvester#5137, in Harvester v1.3.0, the load-balancer-harvester cannot handle vmi correctly (client still use v0.5.4), causes the feature is partially broken.

Note:
In v1.3.0, when a VM is created, and there is no LB related configuration, the LB pod still flood such log

time="2024-02-08T16:54:39Z" level=error msg="error syncing 'default/vm1': handler harvester-lb-vmi-controller: admission webhook "virtualmachineinstances-update-validator.kubevirt.io" denied the request: update of VMI object is restricted, requeuing"

With this PR, such log is gone, and the VM is correctly added a wrangler.cattle.io/harvester-lb-vmi-controller finalizer.

Other bug fix is not related to this PR, and will be further on top of this PR in future.

PR harvester/harvester#4787 is referred to bump all those dependencies.

Todo: After this PR is merged, we need to release a new version and update the chart.

BTW:
also note issue
kubernetes/kube-openapi#404

and the solution:
prometheus-operator/prometheus-operator#5667 (comment)

In harvester and load-balancer-harvester, the used openapi version is:
k8s.io/kube-openapi => k8s.io/kube-openapi v0.0.0-20230308215209-15aac26d736a

@w13915984028 w13915984028 requested review from FrankYang0529, bk201 and starbops and removed request for FrankYang0529 March 8, 2024 21:28
@w13915984028 w13915984028 changed the title Bump kubevirt to v1.0.0, k8s to v1.26.10, Harvester to v1.3.0 Bump kubevirt to v1.1.0, k8s to v1.26.10, Harvester to v1.3.0 Mar 8, 2024
Signed-off-by: Jian Wang <w13915984028@gmail.com>
Copy link
Member

@starbops starbops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that with this fix, the error messages no long exist in the load-balancer Pod. LGTM, thank you!

Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants