Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling eth_getBlockByNumber/eth_getBlockByHash performance improvement when showDetails flag is false #840

Closed
lukelee-sl opened this issue Jan 25, 2023 · 0 comments · Fixed by #842
Closed

Calling eth_getBlockByNumber/eth_getBlockByHash performance improvement when showDetails flag is false #840

lukelee-sl opened this issue Jan 25, 2023 · 0 comments · Fixed by #842
Assignees
@lukelee-sl
Labels
bug Something isn't working
Milestone
0.16.0

Comments

@lukelee-sl
Copy link
Member

Description

Calls to eth_getBlockByNumber/eth_getBlockByNumber both take a parameter called showDetails. In the case where this parameter is false, we return a list of transaction hashes. This list can be more efficiently derived from the initial set of contract results within a block rather than calling the mirror node for each contract results.

Steps to reproduce

Found when investigating issue #827. Execute the curl command from that issue and trace through the resultant logs.

Additional context

No response

Hedera network

testnet

Version

v0.16.0-rc2

Operating system

macOS
@lukelee-sl lukelee-sl added the bug Something isn't working label Jan 25, 2023
@lukelee-sl lukelee-sl self-assigned this Jan 25, 2023
@lukelee-sl lukelee-sl added this to the 0.16.0 milestone Jan 25, 2023
This was referenced Jan 25, 2023
Closed
Merged
@lukelee-sl lukelee-sl mentioned this issue Jan 26, 2023
Merged
lukelee-sl added a commit that referenced this issue Jan 26, 2023
@lukelee-sl
Cherry pick #840 (#843)
c8351ff 
Remove unnecessary call when details not requested (#842)

Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>

Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>

Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukelee-sl lukelee-sl

Labels
bug Something isn't working
Projects
Smart Contract Sprint Board
Archived in project
Milestone
0.16.0
Development

Successfully merging a pull request may close this issue.

Remove unnecessary call when details not requested hashgraph/hedera-json-rpc-relay
1 participant
@lukelee-sl