Remove unnecessary call when details not requested #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
lukelee-sl
requested review from
ebadiere,
georgi-l95,
Nana-EC,
david-bakin-sl and
AlfredoG87
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportBase: 73.90% // Head: 73.76% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #842 +/- ##
==========================================
- Coverage 73.90% 73.76% -0.14%
==========================================
Files 29 29
Lines 1774 1776 +2
Branches 323 323
==========================================
- Hits 1311 1310 -1
- Misses 370 372 +2
- Partials 93 94 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Nana-EC
approved these changes
Jan 26, 2023
lukelee-sl
added a commit
that referenced
this pull request
Jan 26, 2023
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com> Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
lukelee-sl
added a commit
that referenced
this pull request
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lukelee-sl luke.lee@swirldslabs.com
Description:
Do not make additional calls to the mirror node unnecessarily when
showDetailsparameter is false. The transaction hash is already available in the result set from the first call to retrieve contractResults.In the example in issue #827, the block contained 100 contract results. Iterating over them when details were not asked for was needlessly costly.
Related issue(s):
Fixes #840 and #827 (the particular use case in this issue)
Notes for reviewer:
Checklist