Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting a transaction type in Transactions table triggers duplicated api/v1/transactions requests #292

Closed
ericleponner opened this issue Nov 2, 2022 · 0 comments · Fixed by #293
Closed

Setting a transaction type in Transactions table triggers duplicated api/v1/transactions requests #292

ericleponner opened this issue Nov 2, 2022 · 0 comments · Fixed by #293
Assignees
@ericleponner
Labels
bug Something isn't working

Comments

@ericleponner
Copy link
Collaborator

ericleponner commented Nov 2, 2022 •
edited
Loading

Description

Setting a transaction type filter in Recent Transactions table triggers duplicated api/v1/transactions requests.
This is can be seen in Navigator debug panel.

Steps to reproduce

  1. Go to Transactions tab in https://hashscan.io
  2. Open developer panel and display network tab
    => api/v1/transactions are periodically sent to mirror node : OK
  3. Set filter type to Contract Call
    => api/v1/transactions (with type filter) are periodically sent to mirror node : OK
    => api/v1/transactions are sent two by two : KO
    => this keeps going until auto refresh is stopped (automatically or manually)

Step no 3 does not always exhibits duplicated requests : there is a question of timing.
To see duplicates requests, it’s important to set filter type just after a refresh (ie before timer elapses).

When Transactions tab has started to send duplicated requests and user navigates to navigation details, duplicated api/v1/transactions requests continue to flow to mirror node.

Additional context

No response

Hedera network

mainnet

Version

Built Tue, 01 Nov 2022 15:58:34 GMT

Operating system

No response
@ericleponner ericleponner added the bug Something isn't working label Nov 2, 2022
@ericleponner ericleponner self-assigned this Nov 2, 2022
ericleponner added a commit that referenced this issue Nov 2, 2022
@ericleponner
Fix for #292 (Setting a transaction type in Transactions table trigge…
977f2b8 
…rs duplicated api/v1/transactions requests).

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
ericleponner added a commit that referenced this issue Nov 2, 2022
@ericleponner
Added unit tests for #292.
7d2b31d 
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@ericleponner ericleponner mentioned this issue Nov 2, 2022
Merged
2 tasks
svienot pushed a commit that referenced this issue Nov 2, 2022
@ericleponner
00292 Setting a transaction type in Transactions table triggers dupli…
c40627f 
…cated api/v1/transactions requests (#293)

* Fix for #292 (Setting a transaction type in Transactions table triggers duplicated api/v1/transactions requests).

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>

* Added unit tests for #292.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@ericleponner ericleponner mentioned this issue Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericleponner ericleponner

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@ericleponner