Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigating back from Transaction details to Account details does not preserve pagination #307

Closed
ericleponner opened this issue Nov 8, 2022 · 1 comment · Fixed by #308 or #309
Closed

Navigating back from Transaction details to Account details does not preserve pagination #307

ericleponner opened this issue Nov 8, 2022 · 1 comment · Fixed by #308 or #309
Assignees
@ericleponner
Labels
bug Something isn't working

Comments

@ericleponner
Copy link
Collaborator

ericleponner commented Nov 8, 2022 •
edited
Loading

Description

This is a latent issue in TransactionTableControllerXL class, uncovered by fixing #292.

Steps to reproduce

  1. Goto https://hashscan.io
  2. Select mainnet and search for 0.0.21 account (or any other accounts with recent transactions)
  3. In Recent Transactions table, goto page 10
  4. Click to first row
    => Transaction Details are displayed : OK
  5. Click navigator’s back button
    => Account Details are displayed again : OK
    => Recent Transactions table show page nb 1 : KO (this should be 10)

Additional context

No response

Hedera network

mainnet

Version

Fri, 04 Nov 2022 08:28:03 GMT

Operating system

No response
@ericleponner ericleponner added the bug Something isn't working label Nov 8, 2022
@ericleponner ericleponner self-assigned this Nov 8, 2022
ericleponner added a commit that referenced this issue Nov 8, 2022
@ericleponner
Fix for #307 issue (Navigating back from Transaction details to Accou…
6eea6b3 
…nt details does not preserve pagination).

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@ericleponner ericleponner mentioned this issue Nov 8, 2022
Merged
2 tasks
svienot pushed a commit that referenced this issue Nov 8, 2022
@ericleponner
Fix for #307 issue (Navigating back from Transaction details to Accou…
3b6e11c 
…nt details does not preserve pagination). (#308)

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@ericleponner
Copy link
Collaborator Author

This fix does not work : re-opening.

@ericleponner ericleponner reopened this Nov 8, 2022
ericleponner added a commit that referenced this issue Nov 8, 2022
@ericleponner
Take #2 for #307 issue (Navigating back from Transaction details to A…
ee9d71c 
…ccount details does not preserve pagination).

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@ericleponner ericleponner mentioned this issue Nov 8, 2022
Merged
2 tasks
svienot pushed a commit that referenced this issue Nov 8, 2022
@ericleponner
Take #2 for #307 issue (Navigating back from Transaction details to A…
03afa85 
…ccount details does not preserve pagination). (#309)

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Neurone pushed a commit to Neurone/hedera-mirror-node-explorer that referenced this issue May 18, 2023
@ericleponner @Neurone
Fix for hashgraph#307 issue (Navigating back from Transaction details…
738e81e 
… to Account details does not preserve pagination). (hashgraph#308)

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Neurone pushed a commit to Neurone/hedera-mirror-node-explorer that referenced this issue May 18, 2023
@ericleponner @Neurone
Take hashgraph#2 for hashgraph#307 issue (Navigating back from Transa…
bb08137 
…ction details to Account details does not preserve pagination). (hashgraph#309)

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericleponner ericleponner

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@ericleponner