Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update production container image to support block streams #16736

Closed
wants to merge 1 commit into from

Conversation

nathanklick
Copy link
Member

Description

This pull request changes the following:

  • Updates the production container image to support block streams.
  • Updates the default block stream storage location in the consensus node software.

Related Issues

Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick nathanklick requested review from a team as code owners November 22, 2024 05:17
@nathanklick nathanklick added this to the v0.56 milestone Nov 22, 2024
@nathanklick nathanklick added Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. Escape An issue found after the feature was completed, but caught in a testing env prior to a prod release. P0 An issue impacting production environments or impacting multiple releases or multiple individuals. labels Nov 22, 2024
@nathanklick nathanklick self-assigned this Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.35%. Comparing base (81b7849) to head (f1cbec4).

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##             release/0.56   #16736   +/-   ##
===============================================
  Coverage           58.35%   58.35%           
  Complexity          20002    20002           
===============================================
  Files                2738     2738           
  Lines              100493   100493           
  Branches            10378    10378           
===============================================
  Hits                58645    58645           
  Misses              38216    38216           
  Partials             3632     3632           
Files with missing lines Coverage Δ
...com/hedera/node/config/data/BlockStreamConfig.java 100.00% <ø> (ø)

Impacted file tree graph

---- 🚨 Try these New Features:

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (81b7849) 100310 62140 61.95%
Head commit (f1cbec4) 100310 (+0) 62140 (+0) 61.95% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16736) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Contributor

@netopyr netopyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be an incomplete duplicate of #16719

@nathanklick
Copy link
Member Author

This seems to be an incomplete duplicate of #16719

@netopyr This is the bare minimum required for 0.56 to support block streams on testnet/mainnet. I thought the goal was to minimize changes in 0.56.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Escape An issue found after the feature was completed, but caught in a testing env prior to a prod release. Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P0 An issue impacting production environments or impacting multiple releases or multiple individuals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants