Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Modify and mount default block streams output directory #16719

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

mhess-swl
Copy link
Member

@mhess-swl mhess-swl commented Nov 21, 2024

This PR modifies the default block streams output directory to /opt/hgcapp/blockStreams in order to match the corresponding record streams directory. This directory is also added as a mount in the relevant docker compose files.

Closes #16713

Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
@mhess-swl mhess-swl added the Release Issues tied to release management functions. label Nov 21, 2024
@mhess-swl mhess-swl self-assigned this Nov 21, 2024
@mhess-swl mhess-swl requested review from a team as code owners November 21, 2024 17:55
@mhess-swl mhess-swl changed the title Modify and mount default block streams output directory config: Modify and mount default block streams output directory Nov 21, 2024
@mhess-swl mhess-swl added this to the v0.56 milestone Nov 21, 2024
@mhess-swl mhess-swl assigned mhess-swl and unassigned mhess-swl Nov 21, 2024
@mhess-swl mhess-swl changed the title config: Modify and mount default block streams output directory chore: Modify and mount default block streams output directory Nov 21, 2024
@mhess-swl mhess-swl assigned mhess-swl and unassigned mhess-swl Nov 21, 2024
@mhess-swl
Copy link
Member Author

@nathanklick please review, especially for any downstream effects to NMT

Copy link

codacy-production bot commented Nov 21, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.16% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5dc2d36) 97267 63449 65.23%
Head commit (ee8b33a) 96901 (-366) 63058 (-391) 65.07% (-0.16%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16719) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.45%. Comparing base (5dc2d36) to head (ee8b33a).
Report is 21 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16719      +/-   ##
=============================================
- Coverage      63.52%   63.45%   -0.07%     
- Complexity     20302    20319      +17     
=============================================
  Files           2544     2545       +1     
  Lines          94502    94605     +103     
  Branches        9871     9878       +7     
=============================================
+ Hits           60030    60035       +5     
- Misses         30864    30954      +90     
- Partials        3608     3616       +8     
Files with missing lines Coverage Δ
...com/hedera/node/config/data/BlockStreamConfig.java 100.00% <ø> (ø)

... and 65 files with indirect coverage changes

Impacted file tree graph

---- 🚨 Try these New Features:

Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
@mhess-swl mhess-swl requested a review from a team as a code owner November 22, 2024 16:45
@mhess-swl mhess-swl requested a review from a team as a code owner November 22, 2024 16:45
dalvizu
dalvizu previously approved these changes Nov 22, 2024
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
dalvizu
dalvizu previously approved these changes Nov 22, 2024
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mhess-swl

@mhess-swl mhess-swl merged commit 6897a54 into develop Nov 22, 2024
52 checks passed
@mhess-swl mhess-swl deleted the 16713-default-block-streams-dir branch November 22, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Issues tied to release management functions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default folder for block streams
5 participants