-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Modify and mount default block streams output directory #16719
Conversation
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
@nathanklick please review, especially for any downstream effects to NMT |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #16719 +/- ##
=============================================
- Coverage 63.52% 63.45% -0.07%
- Complexity 20302 20319 +17
=============================================
Files 2544 2545 +1
Lines 94502 94605 +103
Branches 9871 9878 +7
=============================================
+ Hits 60030 60035 +5
- Misses 30864 30954 +90
- Partials 3608 3616 +8
|
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @mhess-swl
This PR modifies the default block streams output directory to
/opt/hgcapp/blockStreams
in order to match the corresponding record streams directory. This directory is also added as a mount in the relevant docker compose files.Closes #16713