chore: Cover `ScheduleCreate` with recently changed throttle definitions #16820

tinker-michaelj · 2024-11-27T15:54:13Z

Description:

Adds test for scheduling transactions to the same second before and after the network throttle definitions changed.
Cherry-pick chore: Modify and mount default block streams output directory #16719

Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>

Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>

Signed-off-by: ibankov <ivan.bankov@limechain.tech>

…transactions # Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/HandleWorkflow.java

Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>

refactor hapi tests Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>

Signed-off-by: ibankov <ivan.bankov@limechain.tech>

Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>

Signed-off-by: ibankov <ivan.bankov@limechain.tech>

fix long term schedule throttle warning. Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>

…persistence' into 15055-POC-long-term-scheduled-transactions # Conflicts: # hedera-node/hedera-schedule-service-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/HandlerUtility.java # hedera-node/hedera-schedule-service-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/ScheduleCreateHandler.java # hedera-node/hedera-schedule-service-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/ScheduleDeleteHandler.java # hedera-node/hedera-schedule-service-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/ScheduleManager.java # hedera-node/hedera-schedule-service-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/ScheduleSignHandler.java # hedera-node/hedera-schedule-service-impl/src/test/java/com/hedera/node/app/service/schedule/impl/handlers/HandlerUtilityTest.java # hedera-node/hedera-schedule-service-impl/src/test/java/com/hedera/node/app/service/schedule/impl/handlers/ScheduleCreateHandlerTest.java # hedera-node/hedera-schedule-service-impl/src/test/java/com/hedera/node/app/service/schedule/impl/handlers/ScheduleManagerTest.java

Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>

Signed-off-by: ibankov <ivan.bankov@limechain.tech>

…transactions # Conflicts: # hedera-node/hedera-schedule-service-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/AbstractScheduleHandler.java # hedera-node/hedera-schedule-service-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/HandlerUtility.java # hedera-node/hedera-schedule-service-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/ScheduleCreateHandler.java # hedera-node/hedera-schedule-service-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/ScheduleDeleteHandler.java # hedera-node/hedera-schedule-service-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/ScheduleSignHandler.java

…transactions # Conflicts: # hedera-node/hedera-app/src/test/java/com/hedera/node/app/workflows/handle/HandleWorkflowTest.java # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/queries/schedule/HapiGetScheduleInfo.java

Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech> Co-authored-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech> Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com>

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>

codecov · 2024-11-27T16:14:41Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.63%. Comparing base (1b4339d) to head (9244d71).

Additional details and impacted files

@@                Coverage Diff                 @@
##             release/0.57   #16820      +/-   ##
==================================================
+ Coverage           63.59%   63.63%   +0.04%     
- Complexity          20399    20413      +14     
==================================================
  Files                2547     2547              
  Lines               94875    94896      +21     
  Branches             9913     9914       +1     
==================================================
+ Hits                60335    60389      +54     
+ Misses              30922    30891      -31     
+ Partials             3618     3616       -2

Files with missing lines	Coverage Δ
...com/hedera/node/config/data/BlockStreamConfig.java	`100.00% <ø> (ø)`
.../schedule/impl/handlers/ScheduleCreateHandler.java	`92.65% <100.00%> (+1.62%)`	⬆️

... and 9 files with indirect coverage changes

codacy-production · 2024-11-27T16:14:51Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.04% (target: -1.00%)	✅ 100.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`1b4339d`)	97640	63764	65.31%
Head commit (`9244d71`)	97661 (+21)	63816 (+52)	65.34% (+0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#16820)	23	23	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>

Neeharika-Sompalli

LGTM! Thanks @tinker-michaelj

JivkoKelchev and others added 30 commits October 16, 2024 10:13

enable long term schedule transactions

2149b34

Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>

nit: add a simple comment

25fefc0

Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>

fix schedule sign longterm

6d70cfc

Signed-off-by: ibankov <ivan.bankov@limechain.tech>

additional tests

8a46546

Signed-off-by: ibankov <ivan.bankov@limechain.tech>

Merge branch 'refs/heads/develop' into 15055-POC-long-term-scheduled-…

0bbe343

…transactions # Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/HandleWorkflow.java

fix merge conflicts

ae99cba

Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>

revert SchedulingConfig

a560341

refactor hapi tests Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>

Add signingCryptoKeys() to AppKeyVerifier

99060db

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>

spotless

0cc535d

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>

Standarize some stylistic things

a0e1ad6

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>

spotless

8782b71

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>

fix unit test

af02776

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>

Merge upstream

cf39c77

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>

fix checkModuleInfo

89d550c

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>

fix unit test

68149f8

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>

LongTerm feature flag tests, and fixes

be2d792

Signed-off-by: ibankov <ivan.bankov@limechain.tech>

fix test

753e11c

Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>

fix unit test

cffc354

Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>

fix unit test

064d33e

Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>

fix unit test ScheduleCreateHandlerTest

1cf47a8

Signed-off-by: ibankov <ivan.bankov@limechain.tech>

longer time to expiry for ScheduleLongTermExecutionSpecs

3299b2a

Signed-off-by: ibankov <ivan.bankov@limechain.tech>

fix fake upgrade error.

e0d80b6

fix long term schedule throttle warning. Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>

fix merge conflicts

b64f9d0

Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>

spotless and add fees for schedule_create_contract_call

b43b9a7

Signed-off-by: ibankov <ivan.bankov@limechain.tech>

port ScheduleLongTermSignSuite from mono

913b3e8

Signed-off-by: ibankov <ivan.bankov@limechain.tech>

revert unnecessary changes

48cc80f

Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>

revert unnecessary changes

2730cec

Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>

tinker-michaelj and others added 5 commits November 25, 2024 01:28

Remove dead code

c86922d

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>

intermezzo

10c48af

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>

Merge upstream

245d544

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>

Add test for changing throttle definitions

57d0699

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>

tinker-michaelj requested review from a team, rbair23, dalvizu, poulok, netopyr, Nana-EC, SimiHunjan, steven-sheehy, nathanklick and jsync-swirlds as code owners November 27, 2024 15:54

tinker-michaelj requested a review from imalygin November 27, 2024 15:54

tinker-michaelj added this to the v0.57 milestone Nov 27, 2024

tinker-michaelj self-assigned this Nov 27, 2024

tinker-michaelj mentioned this pull request Nov 27, 2024

chore: Cover changing throttle definitions #16821

Open

Revert unrelated changes

9244d71

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>

Neeharika-Sompalli approved these changes Nov 27, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Cover `ScheduleCreate` with recently changed throttle definitions #16820

chore: Cover `ScheduleCreate` with recently changed throttle definitions #16820

tinker-michaelj commented Nov 27, 2024 •

edited

Loading

codecov bot commented Nov 27, 2024 •

edited

Loading

codacy-production bot commented Nov 27, 2024 •

edited

Loading

Neeharika-Sompalli left a comment

chore: Cover ScheduleCreate with recently changed throttle definitions #16820

Are you sure you want to change the base?

chore: Cover ScheduleCreate with recently changed throttle definitions #16820

Conversation

tinker-michaelj commented Nov 27, 2024 • edited Loading

codecov bot commented Nov 27, 2024 • edited Loading

Codecov Report

codacy-production bot commented Nov 27, 2024 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

chore: Cover `ScheduleCreate` with recently changed throttle definitions #16820

chore: Cover `ScheduleCreate` with recently changed throttle definitions #16820

tinker-michaelj commented Nov 27, 2024 •

edited

Loading

codecov bot commented Nov 27, 2024 •

edited

Loading

codacy-production bot commented Nov 27, 2024 •

edited

Loading