Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cover changing throttle definitions #16821

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tinker-michaelj
Copy link
Collaborator

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj tinker-michaelj added this to the v0.58 milestone Nov 27, 2024
@tinker-michaelj tinker-michaelj self-assigned this Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.67%. Comparing base (d43a749) to head (435fe5a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16821      +/-   ##
=============================================
+ Coverage      63.53%   63.67%   +0.14%     
- Complexity     20371    20419      +48     
=============================================
  Files           2537     2537              
  Lines          94757    94778      +21     
  Branches        9904     9905       +1     
=============================================
+ Hits           60203    60353     +150     
+ Misses         30948    30821     -127     
+ Partials        3606     3604       -2     
Files with missing lines Coverage Δ
.../schedule/impl/handlers/ScheduleCreateHandler.java 92.65% <100.00%> (+1.62%) ⬆️

... and 21 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Nov 27, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.14% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d43a749) 97522 63620 65.24%
Head commit (435fe5a) 97543 (+21) 63767 (+147) 65.37% (+0.14%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16821) 23 23 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant