Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable opt-in legacy authentication flow #595

Merged
merged 2 commits into from
Aug 14, 2023
Merged

feat: enable opt-in legacy authentication flow #595

merged 2 commits into from
Aug 14, 2023

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Aug 4, 2023

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Adds an opt-in "legacy" workflow to support the Terraform core S3 backend upgrade which will span multiple minor versions.

$ go test -count=1 ./...
?       github.com/hashicorp/aws-sdk-go-base/v2/internal/awsconfig      [no test files]
?       github.com/hashicorp/aws-sdk-go-base/v2/internal/config [no test files]
?       github.com/hashicorp/aws-sdk-go-base/v2/internal/constants      [no test files]
?       github.com/hashicorp/aws-sdk-go-base/v2/internal/errs   [no test files]
?       github.com/hashicorp/aws-sdk-go-base/v2/internal/slices [no test files]
?       github.com/hashicorp/aws-sdk-go-base/v2/internal/test   [no test files]
?       github.com/hashicorp/aws-sdk-go-base/v2/mockdata        [no test files]
?       github.com/hashicorp/aws-sdk-go-base/v2/servicemocks    [no test files]
ok      github.com/hashicorp/aws-sdk-go-base/v2 5.441s
ok      github.com/hashicorp/aws-sdk-go-base/v2/diag    0.296s
ok      github.com/hashicorp/aws-sdk-go-base/v2/internal/endpoints      0.188s
ok      github.com/hashicorp/aws-sdk-go-base/v2/internal/expand 0.237s
ok      github.com/hashicorp/aws-sdk-go-base/v2/logging 0.225s
ok      github.com/hashicorp/aws-sdk-go-base/v2/tfawserr        0.289s
ok      github.com/hashicorp/aws-sdk-go-base/v2/useragent       0.336s

@jar-b jar-b marked this pull request as ready for review August 10, 2023 13:23
@jar-b jar-b requested a review from a team as a code owner August 10, 2023 13:23
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants