Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend/s3: add use_legacy_workflow argument to modernization branch #33716

Merged
merged 4 commits into from
Aug 22, 2023

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Aug 21, 2023

Adds an optional use_legacy_workflow argument to preserve the authentication flow aws-sdk-go-base V1 implemented. This does not align with the flow of the AWS CLI or SDK's and will be phased out over several minor releases. In v1.6.0 this argument will default to true (ie. no user facing changes).

% TF_ACC=1 go test -count=1 ./internal/backend/remote-state/s3/...
ok      github.com/hashicorp/terraform/internal/backend/remote-state/s3 103.779s

Relates #33631
Relates #30443
Relates hashicorp/aws-sdk-go-base#595

Target Release

1.6.0

@jar-b jar-b requested a review from a team as a code owner August 21, 2023 20:37
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise looks good 🚀

internal/backend/remote-state/s3/backend.go Outdated Show resolved Hide resolved
@jar-b
Copy link
Member Author

jar-b commented Aug 22, 2023

Removed the deprecation and added one additional test case to cover an explicitly disabled legacy workflow.

% TF_ACC=1 go test -count=1 ./internal/backend/remote-state/s3/...
ok      github.com/hashicorp/terraform/internal/backend/remote-state/s3 98.150s

@jar-b jar-b merged commit d996623 into s3/modernization Aug 22, 2023
@jar-b jar-b deleted the s3/use-legacy-workflow branch August 22, 2023 14:22
@github-actions
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants