This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
Update testify to version that resolves CVE-2022-28948 #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our current version of Testify is pulling in a version of gopkg.in/yaml.v3 that contains CVE-2022-28948. The latest version of testify resolves this by updating its yaml.v3 dependency
nathancoleman
added
the
pr/no-changelog
mikemorris
approved these changes
Jun 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Our current version of Testify is pulling in a version of
gopkg.in/yaml.v3that contains CVE-2022-28948. The latest version of testify resolves this by updating itsyaml.v3dependency w/ stretchr/testify#1192$ go mod why gopkg.in/yaml.v3 # gopkg.in/yaml.v3 github.com/hashicorp/consul-api-gateway/internal/adapters/consul github.com/hashicorp/consul-api-gateway/internal/adapters/consul.test github.com/stretchr/testify/assert gopkg.in/yaml.v3How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: