Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gopkg.in/yaml.v3 #1192

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Conversation

ingwarsw
Copy link
Contributor

@ingwarsw ingwarsw commented May 27, 2022

Seems to fix CVE-2022-28948

@Jacalz
Copy link

Jacalz commented Jun 1, 2022

cc @boyan-soubachov

Copy link
Collaborator

@boyan-soubachov boyan-soubachov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@boyan-soubachov boyan-soubachov merged commit 41453c0 into stretchr:master Jun 6, 2022
@ingwarsw ingwarsw deleted the update-yaml branch June 6, 2022 09:58
zeroshade pushed a commit to apache/arrow that referenced this pull request Jun 10, 2022
…aml.v3 (v7)

This PR updates the github.com/stretchr/testify dependency to get a security patch for gopkg.in/yaml.v3 which has a DoS exploit. See stretchr/testify#1192 for more details.

I'm unsure how this project handles security patches for appears to be older versions. I'm here because I have dependencies that rely on v7, so that's what is bringing me here to make this very particular change. It looks like v6.0.0 and v6.0.1 tags exist, so I expect merging this here and tagging v7.0.1 would be the path forward. If not, let me know what would be preferred.

The linked Jira issue also calls out v8.0.0 as having the same vulnerability, but that would need to be addressed in it's own PR.

Closes #13322 from dominicbarnes/go-security-patch-testify

Authored-by: Dominic Barnes <dominic@dbarnes.info>
Signed-off-by: Matthew Topol <mtopol@factset.com>
dominicbarnes added a commit to segment-boneyard/arrow that referenced this pull request Jul 12, 2022
…aml.v3 (v7)

This PR updates the github.com/stretchr/testify dependency to get a security patch for gopkg.in/yaml.v3 which has a DoS exploit. See stretchr/testify#1192 for more details.

I'm unsure how this project handles security patches for appears to be older versions. I'm here because I have dependencies that rely on v7, so that's what is bringing me here to make this very particular change. It looks like v6.0.0 and v6.0.1 tags exist, so I expect merging this here and tagging v7.0.1 would be the path forward. If not, let me know what would be preferred.

The linked Jira issue also calls out v8.0.0 as having the same vulnerability, but that would need to be addressed in it's own PR.

Closes apache#13322 from dominicbarnes/go-security-patch-testify

Authored-by: Dominic Barnes <dominic@dbarnes.info>
Signed-off-by: Matthew Topol <mtopol@factset.com>
dominicbarnes added a commit to segment-boneyard/arrow that referenced this pull request Jul 12, 2022
…aml.v3 (v7)

This PR updates the github.com/stretchr/testify dependency to get a security patch for gopkg.in/yaml.v3 which has a DoS exploit. See stretchr/testify#1192 for more details.

I'm unsure how this project handles security patches for appears to be older versions. I'm here because I have dependencies that rely on v7, so that's what is bringing me here to make this very particular change. It looks like v6.0.0 and v6.0.1 tags exist, so I expect merging this here and tagging v7.0.1 would be the path forward. If not, let me know what would be preferred.

The linked Jira issue also calls out v8.0.0 as having the same vulnerability, but that would need to be addressed in it's own PR.

Closes apache#13322 from dominicbarnes/go-security-patch-testify

Authored-by: Dominic Barnes <dominic@dbarnes.info>
Signed-off-by: Matthew Topol <mtopol@factset.com>
dominicbarnes added a commit to segment-boneyard/arrow that referenced this pull request Jul 12, 2022
…aml.v3 (v7)

This PR updates the github.com/stretchr/testify dependency to get a security patch for gopkg.in/yaml.v3 which has a DoS exploit. See stretchr/testify#1192 for more details.

I'm unsure how this project handles security patches for appears to be older versions. I'm here because I have dependencies that rely on v7, so that's what is bringing me here to make this very particular change. It looks like v6.0.0 and v6.0.1 tags exist, so I expect merging this here and tagging v7.0.1 would be the path forward. If not, let me know what would be preferred.

The linked Jira issue also calls out v8.0.0 as having the same vulnerability, but that would need to be addressed in it's own PR.

Closes apache#13322 from dominicbarnes/go-security-patch-testify

Authored-by: Dominic Barnes <dominic@dbarnes.info>
Signed-off-by: Matthew Topol <mtopol@factset.com>
dominicbarnes added a commit to segment-boneyard/arrow that referenced this pull request Jul 14, 2022
…aml.v3 (v7)

This PR updates the github.com/stretchr/testify dependency to get a security patch for gopkg.in/yaml.v3 which has a DoS exploit. See stretchr/testify#1192 for more details.

I'm unsure how this project handles security patches for appears to be older versions. I'm here because I have dependencies that rely on v7, so that's what is bringing me here to make this very particular change. It looks like v6.0.0 and v6.0.1 tags exist, so I expect merging this here and tagging v7.0.1 would be the path forward. If not, let me know what would be preferred.

The linked Jira issue also calls out v8.0.0 as having the same vulnerability, but that would need to be addressed in it's own PR.

Closes apache#13322 from dominicbarnes/go-security-patch-testify

Authored-by: Dominic Barnes <dominic@dbarnes.info>
Signed-off-by: Matthew Topol <mtopol@factset.com>
@dolmen dolmen added the YAML About YAML and dependency label Mar 19, 2024
@dolmen dolmen added the dependencies Pull requests that update a dependency file label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file YAML About YAML and dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants