This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
Restore inclusion of ReferencePolicy in Grant lookup #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ReferencePolicy needs to be included for backward compatibility; however, it couldn't be included until v0.5.0-rc2 of kubernetes-sigs/gateway-api
nathancoleman
added
pr/no-changelog
sarahalsmiller
approved these changes
Jul 12, 2022
2 tasks
|
After double-checking, this is actually fine. The only place we use ReferencePolicyList infers the type of the list items, so didn't need to be updated, and ReferencePolicy did keep the changes to use ReferenceGrantSpec internally for its' |
|
@mikemorris we did have one panic due to the list type being incorrect; however, that was resolved w/ the merge of #279 which contained the fix you linked from upstream |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
The ReferencePolicy needs to be included for backward compatibility; however, it couldn't be included until v0.5.0-rc2 of kubernetes-sigs/gateway-api which restored the ReferencePolicy CRD to the default set and fixed a listing bug.
v0.5.0-rc2 was consumed in #279, but I wasn't aware of this related TODO until I attempted the Learn guide which still uses the deprecated
ReferencePolicyinstead of the newReferenceGrant.How I've tested this PR:
How I expect reviewers to test this PR:
See above
Checklist: