-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ReferencePolicyList.Items type #1239
fix ReferencePolicyList.Items type #1239
Conversation
Welcome @dprotaso! |
Hi @dprotaso. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Weird - I thought I was a member of the k8s org - does the k8s-sigs have it's own org/membership repo? |
Thanks @dprotaso! /ok-to-test |
Yep, we're under kubernetes-sigs org. Any kubernetes member can join kubernetes-sigs by making a PR like this: |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
When the ReferencePolicy type was added back the list type for that resource actually returns ReferenceGrants instead of ReferencePolicy. This isn't a huge deal but a lot of code generation around k8s types assume a pattern of
XResource
with aXResourceList
having anItems
type of[]XResource
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: