This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Update to latest serviceresolver crd #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
commented
Sep 24, 2020
.circleci/config.yml
Outdated
| @@ -140,7 +140,8 @@ jobs: | |||
| -kubeconfig="$primary_kubeconfig" \ | |||
| -secondary-kubeconfig="$secondary_kubeconfig" \ | |||
| -debug-directory="$TEST_RESULTS/debug" \ | |||
| -consul-k8s-image=hashicorpdev/consul-k8s:crd-controller-base-latest | |||
| -consul-k8s-image=hashicorpdev/consul-k8s:crd-controller-base-latest \ | |||
| -consul-image=hashicorpdev/consul | |||
There was a problem hiding this comment.
This tracks consul master
lkysow
force-pushed
the
crd-controller-resolver-latest
branch
from
347b3b3 to
66873f7
Compare
lkysow
commented
Sep 25, 2020
| @@ -36,6 +36,7 @@ func TestConnectInject(t *testing.T) { | |||
| "global.tls.enabled": strconv.FormatBool(c.secure), | |||
| "global.tls.enableAutoEncrypt": strconv.FormatBool(c.autoEncrypt), | |||
| "global.acls.manageSystemACLs": strconv.FormatBool(c.secure), | |||
| "global.image": "hashicorpdev/consul", | |||
There was a problem hiding this comment.
Will track master which has latest ServiceResolver merged.
ishustava
approved these changes
Sep 25, 2020
lkysow
force-pushed
the
crd-controller-resolver-latest
branch
from
66873f7 to
34c1cdf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to hashicorp/consul-k8s#335