Update to latest serviceresolver code #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnotashwin
approved these changes
Sep 25, 2020
| @@ -7,7 +7,7 @@ require ( | |||
| github.com/digitalocean/godo v1.10.0 // indirect | |||
| github.com/go-logr/logr v0.1.0 | |||
| github.com/google/go-querystring v1.0.0 // indirect | |||
| github.com/hashicorp/consul/api v1.6.0 | |||
| github.com/hashicorp/consul/api v1.4.1-0.20200924193849-85d223b73c1d | |||
There was a problem hiding this comment.
Oh go-lang versioning. A reasonable person would expect this to be v1.6.1-foobar, but not golang
lkysow
force-pushed
the
crd-serviceresolver-latest
branch
from
8da3144 to
77a8f38
Compare
lkysow
force-pushed
the
crd-serviceresolver-latest
branch
from
77a8f38 to
95306dc
Compare
lkysow
requested review from
a team and
ishustava
and removed request for
a team
ishustava
approved these changes
Sep 29, 2020
| } | ||
|
|
||
| type CookieConfig struct { | ||
| // Session generates a session cookie with no expiration. |
There was a problem hiding this comment.
Should it be something like this since it's a bool
Suggested change
| // Session generates a session cookie with no expiration. | |
| // Session determines whether to generate a session cookie with no expiration. |
There was a problem hiding this comment.
Yes that's better, will update. I copied these directly from Consul.
| } | ||
|
|
||
| // Test MatchesConsul for cases that should return false. | ||
| func TestServiceResolver_MatchesConsulFalse(t *testing.T) { |
There was a problem hiding this comment.
Curious, why are you removing this test?
There was a problem hiding this comment.
I removed it because it was testing reflect.DeepEqual. Although the "different type" case is still valid to test I think.
There was a problem hiding this comment.
@ashwin-venkatesh should we add these back in #340?
ndhanushkodi
pushed a commit
to ndhanushkodi/consul-k8s
that referenced
this pull request
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
masterapi version which contains new serviceresolver codematchesConsulimplementation to usereflect.DeepEqualand removes tests to match how we're testing the other methodsCompanion to hashicorp/consul-helm#619