Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: Remove gnupg from Consul k8s container #1882

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Conversation

david-yu
Copy link
Contributor

@david-yu david-yu commented Feb 6, 2023

Changes proposed in this PR:

  • gnupg is likely an artifact from pre-CRT days when we used to validate Consul K8s releases ourselves for publishing with Docker. This is is likely not needed so will attempt removing it.

How I've tested this PR:

  • Acceptance tests

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@david-yu david-yu changed the title Remove gnupg from Consul k8s container Dockerfile: Remove gnupg from Consul k8s container Feb 6, 2023
@david-yu david-yu requested a review from curtbushko February 6, 2023 23:12
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants