Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Dockerfile: Remove gnupg from Consul k8s container into release/1.0.x #1884

Merged

Conversation

thisisnotashwin
Copy link
Contributor

Backport

This PR is auto-generated from #1882 to be assessed for backporting due to the inclusion of the label backport/1.0.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul-k8s/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Changes proposed in this PR:

  • gnupg is likely an artifact from pre-CRT days when we used to validate Consul K8s releases ourselves for publishing with Docker. This is is likely not needed so will attempt removing it.

How I've tested this PR:

  • Acceptance tests

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)


Overview of commits

@thisisnotashwin thisisnotashwin force-pushed the backport/dyu/remove-gnupg/adequately-correct-crane branch from 89f8ad1 to 2b944f9 Compare February 7, 2023 02:01
@david-yu david-yu marked this pull request as ready for review February 7, 2023 02:14
@david-yu david-yu merged commit e9d79ea into release/1.0.x Feb 7, 2023
@david-yu david-yu deleted the backport/dyu/remove-gnupg/adequately-correct-crane branch February 7, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants