-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NET-5272/add docs team code owners to review helm values description #4237
Conversation
43fffc7
to
5a38959
Compare
5a38959
to
014d792
Compare
014d792
to
f86f00e
Compare
Please double-check the backport labels for me as I am not sure which versions of K8s we are backporting to now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the note on branch protections! LGTM.
Minor nit, can we add a description to the PR title as well so it's clear from preview links and the squashed merge commit what the change was?
You nailed it! There's also a doc here w/ more info about the backport policy: https://go.hashi.co/consul-backports We also update labels on each major release to gray out and describe old labels as no longer active (and eventually remove them when we're well past the last patch release for that version). |
Changes proposed in this PR
How I've tested this PR
It should take effect in the next PR.
### How I expect reviewers to test this PR ###Checklist