Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of NET-5272/add docs team code owners to review helm values description into release/1.3.x #4252

Draft
wants to merge 1 commit into
base: release/1.3.x
Choose a base branch
from

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #4237 to be assessed for backporting due to the inclusion of the label backport/1.3.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@JadhavPoonam
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: unable to process merge commit: "14a5b7757862958b084601aff7a9c65bab4f3280", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.


Changes proposed in this PR

  • Adds a CODEOWNERS file that would request a review from the docs team when helm values are changed. This review is non-blocking as we don't set the required review setting in the branch protection rules.

How I've tested this PR

It should take effect in the next PR.

### How I expect reviewers to test this PR ###

Checklist


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/NET-5272/add-docs-team-for-code-review/mildly-model-snail branch from 6ec7c51 to 0d03154 Compare August 15, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants