allow return of TemplateConfigMapping to be comparable #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TemplateConfigMapping is used by applications like Nomad that embed consul-template. By returning a map of pointers, the caller can compare them against TemplateConfigs passed into the NewRunner method earlier.
tgross
added a commit
to hashicorp/nomad
that referenced
this pull request
Aug 5, 2019
pulls in configuration option for blacklisting template functions from hashicorp/consul-template#1243 hashicorp/consul-template#1246
tgross
added a commit
to hashicorp/nomad
that referenced
this pull request
Aug 5, 2019
pulls in configuration option for blacklisting template functions from hashicorp/consul-template#1243 hashicorp/consul-template#1246
tgross
added a commit
to hashicorp/nomad
that referenced
this pull request
Aug 5, 2019
pulls in configuration option for blacklisting template functions from hashicorp/consul-template#1243 hashicorp/consul-template#1246
tgross
added a commit
to hashicorp/nomad
that referenced
this pull request
Aug 8, 2019
pulls in configuration option for blacklisting template functions from: hashicorp/consul-template#1243 hashicorp/consul-template#1246 pulls in configuration option for file sandboxing from: hashicorp/consul-template#1249
tgross
added a commit
to hashicorp/nomad
that referenced
this pull request
Aug 8, 2019
pulls in configuration option for blacklisting template functions from: hashicorp/consul-template#1243 hashicorp/consul-template#1246 pulls in configuration option for file sandboxing from: hashicorp/consul-template#1249
tgross
added a commit
to hashicorp/nomad
that referenced
this pull request
Aug 9, 2019
pulls in configuration option for blacklisting template functions from: hashicorp/consul-template#1243 hashicorp/consul-template#1246 pulls in configuration option for file sandboxing from: hashicorp/consul-template#1249
tgross
added a commit
to hashicorp/nomad
that referenced
this pull request
Aug 9, 2019
pulls in configuration option for blacklisting template functions from: hashicorp/consul-template#1243 hashicorp/consul-template#1246 pulls in configuration option for file sandboxing from: hashicorp/consul-template#1249 hashicorp/consul-template#1254 [wip consul-template]
tgross
added a commit
to hashicorp/nomad
that referenced
this pull request
Aug 12, 2019
pulls in configuration option for blacklisting template functions from: hashicorp/consul-template#1243 hashicorp/consul-template#1246 pulls in configuration option for file sandboxing from: hashicorp/consul-template#1249 hashicorp/consul-template#1254
tgross
added a commit
to hashicorp/nomad
that referenced
this pull request
Aug 12, 2019
pulls in configuration option for blacklisting template functions from: hashicorp/consul-template#1243 hashicorp/consul-template#1246 pulls in configuration option for file sandboxing from: hashicorp/consul-template#1249 hashicorp/consul-template#1254
tgross
added a commit
to hashicorp/nomad
that referenced
this pull request
Aug 12, 2019
pulls in configuration option for blacklisting template functions from: hashicorp/consul-template#1243 hashicorp/consul-template#1246 pulls in configuration option for file sandboxing from: hashicorp/consul-template#1249 hashicorp/consul-template#1254 pulls in vault KVv2 read fixes from: hashicorp/consul-template#1253
tgross
added a commit
to hashicorp/nomad
that referenced
this pull request
Aug 12, 2019
pulls in configuration option for blacklisting template functions from: hashicorp/consul-template#1243 hashicorp/consul-template#1246 pulls in configuration option for file sandboxing from: hashicorp/consul-template#1249 hashicorp/consul-template#1254 pulls in vault KVv2 read fixes from: hashicorp/consul-template#1253
tgross
added a commit
to hashicorp/nomad
that referenced
this pull request
Aug 12, 2019
pulls in configuration option for blacklisting template functions from: hashicorp/consul-template#1243 hashicorp/consul-template#1246 pulls in configuration option for file sandboxing from: hashicorp/consul-template#1249 hashicorp/consul-template#1254 pulls in vault KVv2 read fixes from: hashicorp/consul-template#1253
tgross
added a commit
to hashicorp/nomad
that referenced
this pull request
Aug 12, 2019
pulls in configuration option for blacklisting template functions from: hashicorp/consul-template#1243 hashicorp/consul-template#1246 pulls in configuration option for file sandboxing from: hashicorp/consul-template#1249 hashicorp/consul-template#1254 pulls in vault KVv2 read fixes from: hashicorp/consul-template#1253
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TemplateConfigMapping is used by applications like Nomad that embed
consul-template. By returning a map of pointers, the caller can
compare them against TemplateConfigs passed into the NewRunner method
earlier.
cc @eikenb as we discussed