Read paths unmodified if KVv2 status check fails #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When vault.read fails to determine whether a path is KVv2, assume it's KVv1 and read from the path as passed from user. Here we fallback to behavior prior to hashicorp#1180, so KVv2 check is for enhancement only. If user truely lacks access, the secret lookup call would fail and we report error back. A customer hit a regression after they upgraded nomad with updated consul-template, where their templates failed to read approle info because isKVv2 returned an error. The case is reproduced in `TestVaultReadQuery_Fetch_NonSecrets` test.
|
I like this change better than what cv and I talked about yesterday. Simple and clear. |
notnoop
pushed a commit
to hashicorp/nomad
that referenced
this pull request
Aug 12, 2019
Pick up hashicorp/consul-template#1253 Fixed dependencies related to `github.com/burntsushi/toml` to `github.com/burntsushi/toml` change.
tgross
added a commit
to hashicorp/nomad
that referenced
this pull request
Aug 12, 2019
pulls in configuration option for blacklisting template functions from: hashicorp/consul-template#1243 hashicorp/consul-template#1246 pulls in configuration option for file sandboxing from: hashicorp/consul-template#1249 hashicorp/consul-template#1254 pulls in vault KVv2 read fixes from: hashicorp/consul-template#1253
tgross
added a commit
to hashicorp/nomad
that referenced
this pull request
Aug 12, 2019
pulls in configuration option for blacklisting template functions from: hashicorp/consul-template#1243 hashicorp/consul-template#1246 pulls in configuration option for file sandboxing from: hashicorp/consul-template#1249 hashicorp/consul-template#1254 pulls in vault KVv2 read fixes from: hashicorp/consul-template#1253
tgross
added a commit
to hashicorp/nomad
that referenced
this pull request
Aug 12, 2019
pulls in configuration option for blacklisting template functions from: hashicorp/consul-template#1243 hashicorp/consul-template#1246 pulls in configuration option for file sandboxing from: hashicorp/consul-template#1249 hashicorp/consul-template#1254 pulls in vault KVv2 read fixes from: hashicorp/consul-template#1253
tgross
added a commit
to hashicorp/nomad
that referenced
this pull request
Aug 12, 2019
pulls in configuration option for blacklisting template functions from: hashicorp/consul-template#1243 hashicorp/consul-template#1246 pulls in configuration option for file sandboxing from: hashicorp/consul-template#1249 hashicorp/consul-template#1254 pulls in vault KVv2 read fixes from: hashicorp/consul-template#1253
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When vault.read fails to determine whether a path is KVv2, assume it's
KVv1 and read from the path as passed from user.
Here we fallback to behavior prior to #1180,
so KVv2 check is for enhancement only. If user truely lacks access, the
secret lookup call would fail and we report error back.
A customer hit a regression after they upgraded nomad with updated
consul-template, where their templates failed to read approle info
because isKVv2 returned an error. The case is reproduced in
TestVaultReadQuery_Fetch_NonSecretstest.