Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read paths unmodified if KVv2 status check fails #1253

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Read paths unmodified if KVv2 status check fails #1253

merged 1 commit into from
Aug 9, 2019

Commits on Aug 9, 2019

  1. Read paths unmodified if KVv2 status check fails 

    When vault.read fails to determine whether a path is KVv2, assume it's
KVv1 and read from the path as passed from user.

Here we fallback to behavior prior to hashicorp#1180,
so KVv2 check is for enhancement only.  If user truely lacks access, the
secret lookup call would fail and we report error back.

A customer hit a regression after they upgraded nomad with updated
consul-template, where their templates failed to read approle info
because isKVv2 returned an error.  The case is reproduced in
`TestVaultReadQuery_Fetch_NonSecrets` test.
    Mahmood Ali committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    f5549c6 View commit details
    Browse the repository at this point in the history