💜 Cc 7187/purple banner for linking existing clusters #20275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-banner-for-linking-existing-clusters
This reverts commit e6784c4. We'll be doing this in CC-7347
… github.com:hashicorp/consul into CC-7187/purple-banner-for-linking-existing-clusters
chris-hut
deleted the
CC-7187/purple-banner-for-linking-existing-clusters
branch
chris-hut
added a commit
that referenced
this pull request
Mar 11, 2024
This reverts commit 5119667.
chris-hut
added a commit
that referenced
this pull request
Mar 13, 2024
* Revert "feat: add alert to link to hcp modal to ask a user refresh a page; up… (#20682)" This reverts commit dd833d9. * Revert "chor: change cluster name param to have datacenter.name as default value (#20644)" This reverts commit 8425cd0. * Revert "chor: adds informative error message when acls disabled and read-only… (#20600)" This reverts commit 9d712cc. * Revert "Cc 7147 link to hcp modal (#20474)" This reverts commit 8c05e57. * Revert "Add nav bar item to show HCP link status and encourage folks to link (#20370)" This reverts commit 22e6ce0. * Revert "Cc 7145 hcp link status api (#20330)" This reverts commit 049ca10. * Revert "💜 Cc 7187/purple banner for linking existing clusters (#20275)" This reverts commit 5119667.
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
💜 We love purple banners!
This banner is the start of the work allowing users to link their existing Self managed clusters to HCP!
This banner will appear on the services index page:
And will disappear if you:
localStorage)Testing & Reproduction steps
Links
Screenshots
PR Checklist
Follow ups
Once the ability to fetch linking status in https://hashicorp.atlassian.net/browse/CC-7145 lands, I'll create a fresh PR that the other checks that the
hcp-link-statusservice makesReferences