Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chor: adds informative error message when acls disabled and read-only… #20600

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

valeriia-ruban
Copy link
Contributor

… selected

Description

  • Add modal critical alert when acls are disabled
  • Add error message when acls are disabled and read-only selected
Screen.Recording.2024-02-12.at.3.22.17.PM.mov

Testing & Reproduction steps

  1. go to Consul
  2. set cookies: CONSUL_ACLS_ENABLE to 0
  3. Check the link to hcp modal and verify if the critical alert and an error message on selecting read-only are shown

Links

https://hashicorp.atlassian.net/browse/CC-7447

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@valeriia-ruban valeriia-ruban added theme/ui Anything related to the UI pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test backport/1.18 labels Feb 12, 2024
@valeriia-ruban valeriia-ruban force-pushed the link-to-hcp-modal-error-when-acls-disabled branch from 61d2ede to 83cf574 Compare February 13, 2024 00:27
@valeriia-ruban valeriia-ruban merged commit 9d712cc into main Feb 13, 2024
71 checks passed
@valeriia-ruban valeriia-ruban deleted the link-to-hcp-modal-error-when-acls-disabled branch February 13, 2024 22:00
@valeriia-ruban valeriia-ruban restored the link-to-hcp-modal-error-when-acls-disabled branch February 13, 2024 22:39
@valeriia-ruban valeriia-ruban deleted the link-to-hcp-modal-error-when-acls-disabled branch February 13, 2024 22:41
chris-hut added a commit that referenced this pull request Mar 11, 2024
chris-hut added a commit that referenced this pull request Mar 13, 2024
* Revert "feat: add alert to link to hcp modal to ask a user refresh a page; up… (#20682)"

This reverts commit dd833d9.

* Revert "chor: change cluster name param to have datacenter.name as default value (#20644)"

This reverts commit 8425cd0.

* Revert "chor: adds informative error message when acls disabled and read-only… (#20600)"

This reverts commit 9d712cc.

* Revert "Cc 7147 link to hcp modal (#20474)"

This reverts commit 8c05e57.

* Revert "Add nav bar item to show HCP link status and encourage folks to link (#20370)"

This reverts commit 22e6ce0.

* Revert "Cc 7145 hcp link status api (#20330)"

This reverts commit 049ca10.

* Revert "💜 Cc 7187/purple banner for linking existing clusters (#20275)"

This reverts commit 5119667.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants