Add nav bar item to show HCP link status and encourage folks to link #20370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onent-for-some-upcoming-changes
…ink-item-in-the-nav-bar
chris-hut
added
theme/ui
Base automatically changed from
CC-7146/convert-consul-hcp-to-a-simpler-component-for-some-upcoming-changes
to
main
January 27, 2024 00:39
…ink-item-in-the-nav-bar
…ink-item-in-the-nav-bar
chris-hut
commented
Jan 29, 2024
Comment on lines
+8
to
+10
| export default class OperatorAbility extends BaseAbility { | ||
| resource = 'operator'; | ||
| } |
There was a problem hiding this comment.
Would love some eyes on this, from Melissa, we need the operator write permission, is this enough?
By adding this I'm able to do this.abilities.can('write operators'), and it seems to be checking the right permission
chris-hut
commented
Jan 29, 2024
…ink-item-in-the-nav-bar
chris-hut
force-pushed
the
CC-7146/hcp-link-item-in-the-nav-bar
branch
from
c2c1d89 to
ce347ef
Compare
This was referenced Feb 9, 2024
chris-hut
added a commit
that referenced
this pull request
Mar 13, 2024
* Revert "feat: add alert to link to hcp modal to ask a user refresh a page; up… (#20682)" This reverts commit dd833d9. * Revert "chor: change cluster name param to have datacenter.name as default value (#20644)" This reverts commit 8425cd0. * Revert "chor: adds informative error message when acls disabled and read-only… (#20600)" This reverts commit 9d712cc. * Revert "Cc 7147 link to hcp modal (#20474)" This reverts commit 8c05e57. * Revert "Add nav bar item to show HCP link status and encourage folks to link (#20370)" This reverts commit 22e6ce0. * Revert "Cc 7145 hcp link status api (#20330)" This reverts commit 049ca10. * Revert "💜 Cc 7187/purple banner for linking existing clusters (#20275)" This reverts commit 5119667.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want people to link to HCP!
This PR adds a nice little nav bar item to the sidebar letting users view their linked clusters in HCP as well as begin the linking process. (Although the actual linking start - with modal will happen in https://hashicorp.atlassian.net/browse/CC-7147
Testing & Reproduction steps
yarn startNewItem should go awaySTATE_TRUE) and restart ui server - you should see a link to HCP consulBack to HCPlinkLinks
Screenshots
References