Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing map key match operator dispositions #38

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Conversation

schmichael
Copy link
Member

Implements MatchOperator.NotPresentDisposition to determine an operator's behavior when a map key in the selector is not found.

Fixes #35
Replaces #36

Implements MatchOperator.NotPresentDisposition to determine an
operator's behavior when a map key in the selector is not found.

Fixes #35
Replaces #36
@schmichael schmichael requested review from jefferai, mkeeler, a team, modrake and jeanneryan and removed request for a team April 21, 2023 17:00
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@jefferai jefferai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@schmichael schmichael merged commit 700d3b7 into main Apr 26, 2023
@schmichael schmichael deleted the not-pre-disp branch April 26, 2023 19:22
jefferai added a commit to hashicorp/boundary that referenced this pull request Apr 26, 2023
This normalizes behavior around missing map keys. See
hashicorp/go-bexpr#38 for more information.
jefferai added a commit to hashicorp/boundary that referenced this pull request Apr 26, 2023
This normalizes behavior around missing map keys. See
hashicorp/go-bexpr#38 for more information.
schmichael added a commit to hashicorp/nomad that referenced this pull request Apr 26, 2023
schmichael added a commit to hashicorp/nomad that referenced this pull request Apr 27, 2023
schmichael added a commit to hashicorp/nomad that referenced this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparisons against missing map keys return an error unless preceded by an "in" check
4 participants