Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of deps: update go-bexpr from 0.1.11 to 0.1.12 into release/1.3.x #17007

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #16991 to be assessed for backporting due to the inclusion of the label backport/1.3.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

The below text is copied from the body of the original PR.


Pulls in hashicorp/go-bexpr#38

Fixes #16758

Without this fix in the bexpr the test fails with:

=== RUN   TestNode_List_PaginationFiltering/filter_on_meta_key
    node_endpoint_test.go:4420:
                Error Trace:    /home/schmichael/src/nomad/nomad/node_endpoint_test.go:4420
                Error:          Received unexpected error:
                                RPC Error:: 400,failed to read result page: error finding value in datum: /Meta/foo at part 1: couldn't find key "foo"
                Test:           TestNode_List_PaginationFiltering/filter_on_meta_key

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/b-missing-map-key/seriously-communal-pegasus branch from 3730acb to 657a0f5 Compare April 27, 2023 16:02
@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@schmichael
Copy link
Member

Pushed in af7af35

@schmichael schmichael closed this May 1, 2023
@schmichael schmichael deleted the backport/b-missing-map-key/seriously-communal-pegasus branch May 1, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants