Update v2 branch with code from the master branch #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azr
commented
Oct 1, 2020
Comment on lines
+311
to
+331
| func (g *Getter) newS3Client( | ||
| region string, url *url.URL, creds *credentials.Credentials, | ||
| ) (*s3.S3, error) { | ||
| var sess *session.Session | ||
|
|
||
| if profile := url.Query().Get("aws_profile"); profile != "" { | ||
| var err error | ||
| sess, err = session.NewSessionWithOptions(session.Options{ | ||
| Profile: profile, | ||
| SharedConfigState: session.SharedConfigEnable, | ||
| }) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| } else { | ||
| config := g.getAWSConfig(region, url, creds) | ||
| sess = session.New(config) | ||
| } | ||
|
|
||
| return s3.New(sess), nil | ||
| } |
This was referenced Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this brings #256 & #261 into the v2 branch
I had rename Request.Mode to Request.GetMode so that we can have a Request.Mode ( for the umask mode ). Maybe there's a better name than Request.Mode there too