umask final version against master (again) #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoenig
added a commit
to hashicorp/nomad
that referenced
this pull request
May 28, 2020
Fixes #7854 Nomad requires a version of go-getter that is currently in PR (hashicorp/go-getter#256) We also require some recent bug fix to go-getter around the handling of URL redirects. Update our vendor'd copy of go-getter to the newly rebased umask changes so that we can incorporate the latest changes for go-getter.
shoenig
added a commit
to hashicorp/nomad
that referenced
this pull request
May 28, 2020
Fixes #7854 Nomad requires a version of go-getter that is currently in PR (hashicorp/go-getter#256) We also require some recent bug fix to go-getter around the handling of URL redirects. Update our vendor'd copy of go-getter to the newly rebased umask changes so that we can incorporate the latest changes for go-getter.
langmartin
approved these changes
May 28, 2020
notnoop
approved these changes
Sep 16, 2020
|
Nice one ! |
notnoop
pushed a commit
to hashicorp/nomad
that referenced
this pull request
Oct 15, 2020
Update go-getter to the latest release now that hashicorp/go-getter#256 is merged. Also, pick up a xz CVE fix that go-getter merged in hashicorp/go-getter#279 .
fredrikhgrelland
pushed a commit
to fredrikhgrelland/nomad
that referenced
this pull request
Oct 22, 2020
Update go-getter to the latest release now that hashicorp/go-getter#256 is merged. Also, pick up a xz CVE fix that go-getter merged in hashicorp/go-getter#279 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #198 but rebased with master as of May 2020.
Nomad needs a recent fix for hashicorp/nomad#7854
cc @langmartin