-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update go-getter for redirects fix #8069
Conversation
Fixes #7854 Nomad requires a version of go-getter that is currently in PR (hashicorp/go-getter#256) We also require some recent bug fix to go-getter around the handling of URL redirects. Update our vendor'd copy of go-getter to the newly rebased umask changes so that we can incorporate the latest changes for go-getter.
c607b52
to
6215a3d
Compare
To reproduce, $ cat example.nomad
job "example" {
datacenters = ["dc1"]
group "wait" {
task "sleep" {
driver = "exec"
config {
command = "/bin/sleep"
args = ["2000"]
}
artifact {
source = "https://github.com/acmesh-official/acme.sh/archive/2.8.5.tar.gz"
destination = "local/foo"
}
}
}
} before: $ nomad alloc status 6e8
ID = 6e8b91e2-10e8-80a8-6b80-b6bb31e68dc9
Eval ID = 397c2740
Name = example.wait[0]
Node ID = feee6264
Node Name = nzxt
Job ID = example
Job Version = 0
Client Status = pending
Client Description = No tasks have started
Desired Status = run
Desired Description = <none>
Created = 19s ago
Modified = 14s ago
Deployment ID = 068f8cc5
Deployment Health = unset
Task "sleep" is "pending"
Task Resources
CPU Memory Disk Addresses
100 MHz 300 MiB 300 MiB
Task Events:
Started At = N/A
Finished At = N/A
Total Restarts = 1
Last Restart = 2020-05-28T08:37:04-05:00
Recent Events:
Time Type Description
2020-05-28T08:37:04-05:00 Restarting Task restarting in 16.150294481s
2020-05-28T08:37:04-05:00 Failed Artifact Download failed to download artifact "https://github.com/acmesh-official/acme.sh/archive/2.8.5.tar.gz": Error opening a gzip reader for /tmp/getter672924850/archive: EOF
2020-05-28T08:37:04-05:00 Downloading Artifacts Client is downloading artifacts
2020-05-28T08:37:00-05:00 Task Setup Building Task Directory
2020-05-28T08:37:00-05:00 Received Task received by client after: $ nomad alloc status a10
ID = a105bec5-c5be-2209-49b1-e3794173b5d6
Eval ID = 6764baf1
Name = example.wait[0]
Node ID = 5a2f17b6
Node Name = nzxt
Job ID = example
Job Version = 0
Client Status = running
Client Description = Tasks are running
Desired Status = run
Desired Description = <none>
Created = 9s ago
Modified = 5s ago
Deployment ID = a2762b62
Deployment Health = unset
Task "sleep" is "running"
Task Resources
CPU Memory Disk Addresses
0/100 MHz 0 B/300 MiB 300 MiB
Task Events:
Started At = 2020-05-28T13:39:03Z
Finished At = N/A
Total Restarts = 0
Last Restart = N/A
Recent Events:
Time Type Description
2020-05-28T08:39:03-05:00 Started Task started by client
2020-05-28T08:39:02-05:00 Downloading Artifacts Client is downloading artifacts
2020-05-28T08:38:58-05:00 Task Setup Building Task Directory
2020-05-28T08:38:58-05:00 Received Task received by client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Anything I can help with getting the fix merged into go-getter master? Using the branch was a bit confusing.
cherry-picked to 0.11.3 |
deps: update go-getter for redirects fix
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #7854
Nomad requires a version of go-getter that is currently in PR (hashicorp/go-getter#256)
We also require some recent bug fix to go-getter around the handling of URL redirects.
Update our vendor'd copy of go-getter to the newly rebased umask changes so that we can incorporate
the latest changes for go-getter.