Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to download artifact: Error opening a gzip reader for [...]: EOF #7854

Closed
dradtke opened this issue May 1, 2020 · 5 comments · Fixed by #8069
Closed

Failed to download artifact: Error opening a gzip reader for [...]: EOF #7854

dradtke opened this issue May 1, 2020 · 5 comments · Fixed by #8069
Assignees
Labels
theme/dependencies Pull requests that update a dependency file type/bug
Milestone

Comments

@dradtke
Copy link

dradtke commented May 1, 2020

Nomad version

Nomad v0.11.1 (b43457070037800fcc8442c8ff095ff4005dab33)

Operating system and Environment details

openSUSE Leap 15.1 running on Linode

Issue

I have a periodic job that uses acme.sh to renew SSL certificates, and it keeps failing due to an artifact download error.

On the surface it looks like a Github issue, but wget https://github.com/acmesh-official/acme.sh/archive/2.8.5.tar.gz works every time, so it appears to be more specific to how Nomad or go-getter is downloading it.

Job file

Anything with this artifact block:

artifact {
    source = "https://github.com/acmesh-official/acme.sh/archive/2.8.5.tar.gz"
}

Nomad Client logs

Recent Events:
Time                  Type                      Description
2020-05-01T20:34:12Z  Not Restarting            Policy allows no restarts
2020-05-01T20:34:12Z  Failed Artifact Download  failed to download artifact "https://github.com/acmesh-official/acme.sh/archive/2.8.5.tar.gz": Error opening a gzip reader for /tmp/getter780748594/archive: EOF
2020-05-01T20:34:12Z  Downloading Artifacts     Client is downloading artifacts
2020-05-01T20:34:12Z  Task Setup                Building Task Directory
2020-05-01T20:34:12Z  Received                  Task received by client
@shoenig shoenig added the theme/dependencies Pull requests that update a dependency file label May 1, 2020
@shoenig
Copy link
Member

shoenig commented May 1, 2020

I can reproduce/fix this by switching between our vendored version of go-getter and master.

It seems go-getter made a backwards incompatible change since, by removing the Client.Umask field so we'll need to fix that. Or rather, Nomad is using a custom version of go-getter with Client.Umask that does not exist upstream (yet?)

@dradtke
Copy link
Author

dradtke commented May 1, 2020

Any idea when the incompatible version was vendored? I'm curious which Nomad version this would have first appeared in.

@shoenig shoenig added this to the 0.11.2 milestone May 4, 2020
@tgross tgross modified the milestones: 0.11.2, 0.11.3 May 13, 2020
@dradtke
Copy link
Author

dradtke commented May 28, 2020

Looks like this was introduced around version 0.10, since I had to downgrade down to 0.9.7 until this issue is fixed.

@shoenig shoenig added this to Needs Triage in Nomad - Community Issues Triage via automation May 28, 2020
@shoenig shoenig self-assigned this May 28, 2020
shoenig added a commit that referenced this issue May 28, 2020
Fixes #7854

Nomad requires a version of go-getter that is currently in PR (hashicorp/go-getter#256)
We also require some recent bug fix to go-getter around the handling of URL redirects.

Update our vendor'd copy of go-getter to the newly rebased umask changes so that we can incorporate
the latest changes for go-getter.
shoenig added a commit that referenced this issue May 28, 2020
Fixes #7854

Nomad requires a version of go-getter that is currently in PR (hashicorp/go-getter#256)
We also require some recent bug fix to go-getter around the handling of URL redirects.

Update our vendor'd copy of go-getter to the newly rebased umask changes so that we can incorporate
the latest changes for go-getter.
@shoenig shoenig moved this from Needs Triage to In Review in Nomad - Community Issues Triage May 28, 2020
Nomad - Community Issues Triage automation moved this from In Review to Done May 28, 2020
@shoenig
Copy link
Member

shoenig commented May 28, 2020

Sorry about the inconvenience, @dradtke !

We've been using a fork of go-getter that fell behind and needed some recent updates, including a bug fix for redirect handling. The fixes should be in the next release of Nomad (0.11.3)

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme/dependencies Pull requests that update a dependency file type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants