Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Supports .md files? #19

Closed
johnkueh opened this issue Aug 12, 2019 · 1 comment · Fixed by #22
Closed

Supports .md files? #19

johnkueh opened this issue Aug 12, 2019 · 1 comment · Fixed by #22

Comments

@johnkueh
Copy link

The next-mdx plugin allows for matching .md files for compilation, but seems like its not supported here?

next-mdx-enhanced/babelPlugin.js

Lines 13 to 15 in 4413846

// if we're not looking at a .mdx file import, do nothing
const importPath = _path.node.source.value
if (!importPath.match(/\.mdx$/)) return

Will it be an easy one to add? 😊
@jescalan
Copy link
Contributor

jescalan commented Aug 12, 2019 •
edited
Loading

Yeah I'd welcome a pull request to make it configurable! Perhaps an option like matchExtensions - this would be a great first contribution. Please let me know if you're interested in contributing this 😁

My only request is that I'd like to keep only .mdx as the default, since the files are parsed using mdx and not a standard markdown parser. I feel like its best to keep things clear by default.

nfagerlund added a commit to nfagerlund/next-mdx-enhanced that referenced this issue Aug 15, 2019
@nfagerlund
[hashicorp#19] support .md and other file extensions
954f202
nfagerlund added a commit to nfagerlund/next-mdx-enhanced that referenced this issue Aug 15, 2019
@nfagerlund
[hashicorp#19] support .md and other file extensions
27f2aaf
@nfagerlund nfagerlund mentioned this issue Aug 15, 2019
Closed
nfagerlund added a commit to nfagerlund/next-mdx-enhanced that referenced this issue Aug 16, 2019
@nfagerlund
[hashicorp#19] Optionally support .md and other file extensions
907ef7a 
This commit adds a new `fileExtensions` option, which specifies an array of
extensions that should be processed as MDX pages. It defaults to only processing
`.mdx` files.
jescalan pushed a commit that referenced this issue Aug 20, 2019
@nfagerlund @jescalan
[#19] Optionally support .md and other file extensions
f0b696e 
This commit adds a new `fileExtensions` option, which specifies an array of
extensions that should be processed as MDX pages. It defaults to only processing
`.mdx` files.
@jescalan jescalan mentioned this issue Aug 20, 2019
Merged
jescalan pushed a commit that referenced this issue Aug 21, 2019
@nfagerlund @jescalan
[#19] Optionally support .md and other file extensions
9c8b591 
This commit adds a new `fileExtensions` option, which specifies an array of
extensions that should be processed as MDX pages. It defaults to only processing
`.mdx` files.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jescalan @johnkueh