This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
Make fileExtensions configurable #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new `fileExtensions` option, which specifies an array of extensions that should be processed as MDX pages. It defaults to only processing `.mdx` files.
nfagerlund
reviewed
Aug 21, 2019
| pattern: '**/*.mdx', | ||
| pattern: | ||
| pluginOptions.fileExtensions.length > 1 | ||
| ? `**/*.{${pluginOptions.fileExtensions.join(',')}}` |
There was a problem hiding this comment.
Oh huh, does that extended glob syntax misbehave if there's only one thing in it? Or is there another reason for separating them?
There was a problem hiding this comment.
yeah, it didn't work with only one item - you can test it here - thank goodness for tests!
nfagerlund
approved these changes
Aug 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a duplicate of #20, but based off a branch so I could contribute to it. I fixed a number of bugs in the original code and added test coverage for the feature - happy with where it's at right now. Thank you @nfagerlund for the contribution!
Closes #19