Skip to content

Commit

Permalink
ui: move volume link to the source column and fix the link target (#1…
Browse files Browse the repository at this point in the history
…1896)

The link target used the volume name instead of the volume id.
Fixes issue #11884.
  • Loading branch information
NomAnor committed Jan 26, 2022
1 parent 94e55fc commit 045bcd7
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 7 deletions.
3 changes: 3 additions & 0 deletions .changelog/11896.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
ui: Fix the link target for CSI volumes on the task detail page
```
14 changes: 7 additions & 7 deletions ui/app/templates/allocations/allocation/task/index.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -108,18 +108,18 @@
</t.head>
<t.body as |row|>
<tr data-test-volume>
<td data-test-volume-name>
<td data-test-volume-name>{{row.model.volume}}</td>
<td data-test-volume-destination><code>{{row.model.destination}}</code></td>
<td data-test-volume-permissions>{{if row.model.readOnly "Read" "Read/Write"}}</td>
<td data-test-volume-client-source>
{{#if row.model.isCSI}}
<LinkTo @route="csi.volumes.volume" @model={{row.model.volume}} @query={{hash volumeNamespace=row.model.namespace.id}}>
{{row.model.volume}}
<LinkTo @route="csi.volumes.volume" @model={{row.model.source}} @query={{hash volumeNamespace=row.model.namespace.id}}>
{{row.model.source}}
</LinkTo>
{{else}}
{{row.model.volume}}
{{row.model.source}}
{{/if}}
</td>
<td data-test-volume-destination><code>{{row.model.destination}}</code></td>
<td data-test-volume-permissions>{{if row.model.readOnly "Read" "Read/Write"}}</td>
<td data-test-volume-client-source>{{row.model.source}}</td>
</tr>
</t.body>
</ListTable>
Expand Down

0 comments on commit 045bcd7

Please sign in to comment.