Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong link target in UI #11884

Closed
NomAnor opened this issue Jan 19, 2022 · 2 comments
Closed

Wrong link target in UI #11884

NomAnor opened this issue Jan 19, 2022 · 2 comments
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/storage theme/ui type/bug
Projects
Nomad - Community Issues Triage
Milestone
1.3.0

Comments

@NomAnor
Copy link
Contributor

NomAnor commented Jan 19, 2022

Nomad version

Nomad v1.2.3

Issue

The link to the volume on the task site (ui/allocations/<alloc id>/<task name>) shows the volume_mount.volume name from the task but is also linked to ui/csi/volumes/<volume_mount.volume>.

If the volume id form the volume creation/registration file is not the same, the link gives an error.

The label of the link is correct (the task volume name) but the link target must always use the volume id.
@tgross tgross added this to Needs Triage in Nomad - Community Issues Triage via automation Jan 19, 2022
@tgross tgross moved this from Needs Triage to Needs Roadmapping in Nomad - Community Issues Triage Jan 19, 2022
@tgross tgross added the stage/accepted Confirmed, and intend to work on. No timeline committment though. label Jan 19, 2022
NomAnor pushed a commit to NomAnor/nomad that referenced this issue Jan 21, 2022
Move volume link to the source column and fix the link target
97c2f52 
The link target used the volume name instead of the volume id.

Fixes issue hashicorp#11884.
NomAnor added a commit to NomAnor/nomad that referenced this issue Jan 21, 2022
@NomAnor
Move volume link to the source column and fix the link target
3222ede 
The link target used the volume name instead of the volume id.

Fixes issue hashicorp#11884.
tgross pushed a commit that referenced this issue Jan 26, 2022
@NomAnor
ui: move volume link to the source column and fix the link target (#1…
045bcd7 
…1896)

The link target used the volume name instead of the volume id.
Fixes issue #11884.
@tgross tgross added this to the 1.3.0 milestone Jan 26, 2022
@tgross
Copy link
Member

tgross commented Jan 26, 2022

Closed by #11896.

@tgross tgross closed this as completed Jan 26, 2022
Nomad - Community Issues Triage automation moved this from Needs Roadmapping to Done Jan 26, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/storage theme/ui type/bug
Projects
Nomad - Community Issues Triage
Archived in project
Nomad - Community Issues Triage
Done
Milestone
1.3.0
Development

No branches or pull requests
2 participants
@tgross @NomAnor