Skip to content

Commit

Permalink
docs: address more GH-6762 review comments
Browse files Browse the repository at this point in the history
Incorporate suggestions in #6762 (review)

[ci skip]
  • Loading branch information
Mahmood Ali committed Nov 22, 2019
1 parent fd4493c commit 41bf4e8
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions website/source/docs/drivers/docker.html.md
Original file line number Diff line number Diff line change
Expand Up @@ -922,8 +922,8 @@ containers that Nomad starts yet does not manage or track. Though rare, they
lead to unexpectedly running services, potentially with stale versions.

When Docker daemon becomes unavailable as Nomad starts a task, it is possible
for Docker to successfully start the container and fails the API call with 500
error code. In such cases, Nomad retries and eventually aims to kill such
for Docker to successfully start the container but return a 500 error code from
the API call. In such cases, Nomad retries and eventually aims to kill such
containers. However, if the Docker Engine remains unhealthy, subsequent retries
and stop attempts may still fail, and the started container becomes a dangling
container that Nomad no longer manages.
Expand All @@ -933,9 +933,9 @@ containers with a `com.hashicorp.nomad.allocation_id` label, or match Nomad's
conventions for naming and bind-mounts (i.e. `/alloc`, `/secrets`, `local`).
Containers that don't match Nomad container patterns are left untouched.

Operators can run the reaper in a dry run mode, where it only logs dangling
container ids without killing them, or simply disable it through
the `gc.dangling_containers` config stanza.
Operators can run the reaper in a dry-run mode, where it only logs dangling
container ids without killing them, or disable it by setting the
`gc.dangling_containers` config stanza.

### Docker for Windows

Expand Down
2 changes: 1 addition & 1 deletion website/source/guides/upgrade/upgrade-specific.html.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Nomad 0.10.2 addresses an issue occurring in heavily loaded clients, where
containers are started without being properly managed by Nomad. Nomad 0.10.2
introduced a reaper that detects and kills such containers.

Operators may opt to run reaper in a dry mode or disabling it through a client config.
Operators may opt to run reaper in a dry-mode or disabling it through a client config.

For more information, see [Docker Dangling containers][dangling-containers].

Expand Down

0 comments on commit 41bf4e8

Please sign in to comment.