-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document docker dangling container reaper #6762
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! Fairly minor spelling and wording suggestions. Take or leave what you want.
Co-Authored-By: Michael Schurter <mschurter@hashicorp.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some copy edit suggestions. Nothing critical.
It would be nice if the page used -
as the list markdown, because it's the standard, but I know that all of the other pages are a bit of a mixture.
containers are started without being properly managed by Nomad. Nomad 0.10.2 | ||
introduced a reaper that detects and kills such containers. | ||
|
||
Operators may opt to run reaper in a dry mode or disabling it through a client config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Operators may opt to run reaper in a dry mode or disabling it through a client config. | |
Operators may opt to run reaper in a dry-run mode or disabling it through a client config. |
potentially with stale versions. | ||
|
||
When Docker daemon becomes unavailable as Nomad starts a task, it is possible | ||
for Docker to successfully start the container and fails the API call with 500 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for Docker to successfully start the container and fails the API call with 500 | |
for Docker to successfully start the container but return a 500 error code from the API call. |
|
||
When Docker daemon becomes unavailable as Nomad starts a task, it is possible | ||
for Docker to successfully start the container and fails the API call with 500 | ||
error code. In such cases, Nomad retries and eventually aims to kill such |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error code. In such cases, Nomad retries and eventually aims to kill such | |
In such cases, Nomad retries and eventually aims to kill such |
conventions for naming and bind-mounts (i.e. `/alloc`, `/secrets`, `local`). | ||
Containers that don't match Nomad container patterns are left untouched. | ||
|
||
Operators can run the reaper in a dry run mode, where it only logs dangling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Operators can run the reaper in a dry run mode, where it only logs dangling | |
Operators can run the reaper in a dry-run mode, where it only logs dangling |
Containers that don't match Nomad container patterns are left untouched. | ||
|
||
Operators can run the reaper in a dry run mode, where it only logs dangling | ||
container ids without killing them, or simply disable it through |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
container ids without killing them, or simply disable it through | |
container ids without killing them, or disable it by setting |
Incorporate suggestions in #6762 (review) [ci skip]
…rs-followup docs: address more GH-6762 review comments
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Document #6325 .
Specially for grammatical and stylistic comments, please edit to push to branch directly :).