document docker dangling container reaper #6762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notnoop
added
theme/docs
schmichael
approved these changes
Nov 22, 2019
Co-Authored-By: Michael Schurter <mschurter@hashicorp.com>
angrycub
reviewed
Nov 22, 2019
| containers are started without being properly managed by Nomad. Nomad 0.10.2 | ||
| introduced a reaper that detects and kills such containers. | ||
|
|
||
| Operators may opt to run reaper in a dry mode or disabling it through a client config. |
There was a problem hiding this comment.
Suggested change
| Operators may opt to run reaper in a dry mode or disabling it through a client config. | |
| Operators may opt to run reaper in a dry-run mode or disabling it through a client config. |
| potentially with stale versions. | ||
|
|
||
| When Docker daemon becomes unavailable as Nomad starts a task, it is possible | ||
| for Docker to successfully start the container and fails the API call with 500 |
There was a problem hiding this comment.
Suggested change
| for Docker to successfully start the container and fails the API call with 500 | |
| for Docker to successfully start the container but return a 500 error code from the API call. |
|
|
||
| When Docker daemon becomes unavailable as Nomad starts a task, it is possible | ||
| for Docker to successfully start the container and fails the API call with 500 | ||
| error code. In such cases, Nomad retries and eventually aims to kill such |
There was a problem hiding this comment.
Suggested change
| error code. In such cases, Nomad retries and eventually aims to kill such | |
| In such cases, Nomad retries and eventually aims to kill such |
| conventions for naming and bind-mounts (i.e. `/alloc`, `/secrets`, `local`). | ||
| Containers that don't match Nomad container patterns are left untouched. | ||
|
|
||
| Operators can run the reaper in a dry run mode, where it only logs dangling |
There was a problem hiding this comment.
Suggested change
| Operators can run the reaper in a dry run mode, where it only logs dangling | |
| Operators can run the reaper in a dry-run mode, where it only logs dangling |
| Containers that don't match Nomad container patterns are left untouched. | ||
|
|
||
| Operators can run the reaper in a dry run mode, where it only logs dangling | ||
| container ids without killing them, or simply disable it through |
There was a problem hiding this comment.
Suggested change
| container ids without killing them, or simply disable it through | |
| container ids without killing them, or disable it by setting |
notnoop
pushed a commit
that referenced
this pull request
Nov 22, 2019
Incorporate suggestions in #6762 (review) [ci skip]
notnoop
pushed a commit
that referenced
this pull request
Nov 22, 2019
…rs-followup docs: address more GH-6762 review comments
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document #6325 .
Specially for grammatical and stylistic comments, please edit to push to branch directly :).